Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-selection listbox example: Fix aria-selected bug #795

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Single-selection listbox example: Fix aria-selected bug #795

merged 1 commit into from
Aug 13, 2018

Conversation

tryenc
Copy link
Contributor

@tryenc tryenc commented Jul 22, 2018

For issue #794, update aria-selected for single-selection listbox options on focus change in listbox/js/listbox.js:

  • When not multi-selection, toggling aria-selected when option receives or loses focus.

Single-selection listbox example: Fix aria-selected bug
f6f8932 
For issue w3c#794, update aria-selected for single-selection listbox options on focus change in listbox/js/listbox.js:
* When not multi-selection, toggling aria-selected when option receives or loses focus.
@mcking65
Copy link
Contributor

@tryenc, thank you for catching this and submitting a fix.

I also agree with the change to use the checkmark to indicate the selected option in the siggle selects. If I correctly understand the styling, previously the selected item was being identified only by color.

Since there are visual CSS changes, I'd like someone who can see to review. @sh0ji, can you have a look at the CSS changes in this?

@mcking65 mcking65 requested a review from sh0ji August 10, 2018 22:55
@mcking65 mcking65 self-assigned this Aug 10, 2018
sh0ji
sh0ji approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@sh0ji sh0ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The left-padding was previously only being applied on [aria-selected], but now it's always there since there's no longer a scenario where there isn't a checkmark to fill that space.

mcking65 pushed a commit that referenced this pull request Aug 13, 2018
@jongund @mcking65
Navigation Menubar Example: Fix escape key behavior when in menubar o…
15b87d9 
…r in second level submenu (pull #740)

For issues #451 and #795, change escape key processing.
When focus in menubar, close any open submenu.
When focus in second level submenu, close second level menu and focus parent menuitem.
@mcking65
Copy link
Contributor

Thank you @sh0ji, that css change makes sense to me now.

@mcking65 mcking65 merged commit 66229af into w3c:master Aug 13, 2018
@mcking65
Copy link
Contributor

@spectranaut, you will want to merge this into bocoup before doing listbox tests.

This was referenced Aug 14, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0ji sh0ji sh0ji approved these changes

Assignees

@mcking65 mcking65

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tryenc @mcking65 @sh0ji