Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#477) λ¦¬ν”„λ ˆμ‹œ 토큰 λŒ€μ‘ #485

Merged
merged 3 commits into from
Apr 14, 2024
Merged

πŸ”€ :: (#477) λ¦¬ν”„λ ˆμ‹œ 토큰 λŒ€μ‘ #485

merged 3 commits into from
Apr 14, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

PR을 ν•˜κ²Œ 된 λ¬Έμ œμƒν™©, λ°°κ²½ λ“± κ°œμš”μ— λŒ€ν•΄μ„œ μž‘μ„±ν•΄μ£Όμ„Έμš”!

νΌλΈ”λ¦¬μ‹±μ˜ 경우 μŠ€ν¬λ¦°μƒ·/λ™μ˜μƒλ„ μΆ”κ°€ν•΄μ£Όλ©΄ μ’‹μ•„μš”!

API μŠ€νŽ™μ΄ λ³€κ²½λ˜λ©΄μ„œ 기쑴에 μ•‘μ„ΈμŠ€ν† ν°λ§Œ μ‚¬μš©ν•˜λŠ” κ΅¬μ‘°μ—μ„œ λ¦¬ν”„λ ˆμ‹œν† ν°λ„ μ‚¬μš©ν•˜κ²Œ λ³€κ²½λ˜μ—ˆμ–΄μš”.

Resolves: #477

πŸ“ƒ μž‘μ—…λ‚΄μš©

PRμ—μ„œ ν•œ μž‘μ—…μ„ μžμ„Ένžˆ μž‘μ„±ν•΄μ£Όμ„Έμš”!

  • APIμ—μ„œ Refresh토큰을 μ μž¬ν•  수 μžˆλŠ” μ˜΅μ…˜μ„ μΆ”κ°€ν•΄μš”
  • JwtPluginμ—μ„œ refresh token을 λŒ€μ‘ν•΄μš” (솑신, μˆ˜μ‹ )

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!

λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!

e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added the ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ label Apr 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

yongbeomkwak
yongbeomkwak approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν˜Ήμ‹œ λ¦¬ν”„λ ˆμ‹œ 토큰과 , μ΅μŠ€νŒŒμ΄μ–΄ λ™μž‘μ΄ μ–΄λ–»κ²Œ λ˜λŠ”κ±°μ—μš” ??

@baekteun
Copy link
Member Author

baekteun commented Apr 14, 2024 •
edited
Loading

ν˜Ήμ‹œ λ¦¬ν”„λ ˆμ‹œ 토큰과 , μ΅μŠ€νŒŒμ΄μ–΄ λ™μž‘μ΄ μ–΄λ–»κ²Œ λ˜λŠ”κ±°μ—μš” ??

μ§€κΈˆμ€ 별도 λ™μž‘μ€ μ—†μ–΄μš”! μš”μ²­ν• λ•Œ 헀더에 μΆ”κ°€λž‘, Response에 λ°›μ„λ•Œ 킀체인에 μ„Έμ΄λΈŒν•˜λŠ”κ±° μ œμ™Έν•˜κ³ λŠ” μ—†κ³  μ•‘μ„ΈμŠ€ν† ν°μ΄ 만료될 λ•Œ μžλ™λ¦¬ν”„λ ˆμ‹œ λ‘œμ§μ€ #431 μš”κΈ°μ—μ„œ μž‘μ—…ν•΄μ•Όν•΄μš”

@yongbeomkwak
Copy link
Member

ν˜Ήμ‹œ λ¦¬ν”„λ ˆμ‹œ 토큰과 , μ΅μŠ€νŒŒμ΄μ–΄ λ™μž‘μ΄ μ–΄λ–»κ²Œ λ˜λŠ”κ±°μ—μš” ??

μ§€κΈˆμ€ 별도 λ™μž‘μ€ μ—†μ–΄μš”! μš”μ²­ν• λ•Œ 헀더에 μΆ”κ°€λž‘, Response에 λ°›μ„λ•Œ 킀체인에 μ„Έμ΄λΈŒν•˜λŠ”κ±° μ œμ™Έν•˜κ³ λŠ” μ—†κ³  μžλ™λ¦¬ν”„λ ˆμ‹œ λ‘œμ§μ€ #431 μš”κΈ°μ—μ„œ μž‘μ—…ν•΄μ•Όν•΄μš”

μ•„ν•˜ κ·Έλ ‡κ΅°μš” κ°μ‚¬ν•©λ‹ˆλ‹€

@baekteun baekteun merged commit 4d78bf8 into develop Apr 14, 2024
5 checks passed
@baekteun baekteun deleted the 477-support-refresh-token branch April 14, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@baekteun baekteun

Labels
♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
4 participants
@baekteun @yongbeomkwak @KangTaeHoon @youn9k