Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature레이어에서의 Keychain을 직접 사용 코드 리팩토링 #477

Closed
baekteun opened this issue Mar 14, 2024 · 0 comments · Fixed by #485, #486, #487 or #488
Closed

Feature레이어에서의 Keychain을 직접 사용 코드 리팩토링 #477

baekteun opened this issue Mar 14, 2024 · 0 comments · Fixed by #485, #486, #487 or #488
Assignees
@baekteun
Labels
♻️ Refactor 코드 리팩토링

Comments

@baekteun
Copy link
Member

baekteun commented Mar 14, 2024 •
edited
Loading

할 일

Feature 레이어에서 ViewController, ViewModel들이 Keychain을 직접 사용하는 코드가 있어요. (e.g. 로그아웃)
해당 코드들을 리팩토링해요.

  1. UseCase 래핑
  2. LOGOUT 전역함수에서 Noti 날리는 것을 Presentation으로 로직 완전 이동

추가사항

No response
@baekteun baekteun added the ♻️ Refactor 코드 리팩토링 label Mar 14, 2024
@baekteun baekteun self-assigned this Mar 31, 2024
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
✨ :: [#477] Keychain / 저장할 수 있는 Keychain 타입에 refreshToken, 액세스 토큰 만료시…
af70f97 
…간 추가
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] TokenDTO / JwtPlugin에서 Refresh API를 통한 ResponseBody도 대응
dd48f93
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
✨ :: [#477] JwtPlugin / API에 Refresh 토큰 적재 지원
710d42a
@baekteun baekteun mentioned this issue Apr 13, 2024
Merged
5 tasks
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
✨ :: [#477] AuthDomain / Logout UseCase 추가
f63ff78
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
✨ :: [#477] AuthDomain / Logout UseCase 추가
39f7c2c
@baekteun baekteun linked a pull request Apr 13, 2024 that will close this issue
🔀 :: (#477) Logout UseCase 추가 #486
Merged
5 tasks
@baekteun baekteun mentioned this issue Apr 13, 2024
Merged
5 tasks
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
✨ :: [#477] LogoutUseCase 의존성 regist
f8659b3
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] ContainsSongs 화면 / logout 로직 리팩토링
49b131c
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] MultiPurposePopup / logout 로직 리팩토링
2a3270b
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] PlayListDetail / logout 로직 리팩토링
29e47ac
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] ProfilePop / logout 로직 리팩토링
98c90bf
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] Player / logout 로직 리팩토링
87765c8
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] Favorite / logout 로직 리팩토링
a279ee1
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] MyPlayList / logout 로직 리팩토링
a55572b
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
🔥 :: [#477] LOGOUT 전역 함수 제거
b2323b5
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] MyPlayList / logout 로직 리팩토링
41d795c
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
🔥 :: [#477] LOGOUT 전역 함수 제거
a1f6158
@baekteun baekteun mentioned this issue Apr 13, 2024
Merged
5 tasks
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] IntroViewModel / 로그아웃 로직 변경
1c70a18
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] LoginViewModel / keychain 직접 접근 로직 리팩토링
8d0b963
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] AfterLogin logout 로직 리팩토링
055e76b
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
♻️ :: [#477] RequestViewModel / logout 로직 리팩토링
0d1f71f
@baekteun baekteun mentioned this issue Apr 13, 2024
Merged
5 tasks
baekteun added a commit that referenced this issue Apr 13, 2024
@baekteun
🐛 :: [#477] IntroViewModel / 비로그인 상태에서는 인트로 상태에서 넘어갈 수 없어지는 로직 버그
498eb12
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] 비로그인 상태일 시 userInfoResult에 성공 전달
48ce39f
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] NeedleGenerate
2ab0b5c
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] IntroViewModel / 비로그인 상태에서는 인트로 상태에서 넘어갈 수 없어지는 로직 버그
86d4355
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] 비로그인 상태일 시 userInfoResult에 성공 전달
c078e5a
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] NeedleGenerate
e882112
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] IntroViewModel / 로그아웃 로직 변경
2d73362
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] LoginViewModel / keychain 직접 접근 로직 리팩토링
2101dd3
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] AfterLogin logout 로직 리팩토링
c41d054
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] RequestViewModel / logout 로직 리팩토링
ebeb5d9
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] IntroViewModel / 비로그인 상태에서는 인트로 상태에서 넘어갈 수 없어지는 로직 버그
2ffe36e
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] 비로그인 상태일 시 userInfoResult에 성공 전달
6d204dc
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] NeedleGenerate
6fae68d
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
✨ :: [#477] AuthDomain / Logout UseCase 추가
0608cec
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
✨ :: [#477] LogoutUseCase 의존성 regist
564fc47
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
Merge pull request #486 from wakmusic/477-logout-usecase
a5edda4 
🔀 :: (#477) Logout UseCase 추가
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] ContainsSongs 화면 / logout 로직 리팩토링
a60d274
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] MultiPurposePopup / logout 로직 리팩토링
aa026be
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] PlayListDetail / logout 로직 리팩토링
9be09c1
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] ProfilePop / logout 로직 리팩토링
4f54b67
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] Player / logout 로직 리팩토링
d3f3c08
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] Favorite / logout 로직 리팩토링
ebda0e7
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] MyPlayList / logout 로직 리팩토링
5b144bb
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🔥 :: [#477] LOGOUT 전역 함수 제거
9631289
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
Merge pull request #487 from wakmusic/477-logout-logic-refactoring
2366efe 
🔀 :: (#477) Feature 레이어의 로그아웃 로직 리팩토링
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] IntroViewModel / 로그아웃 로직 변경
8ce937c
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] LoginViewModel / keychain 직접 접근 로직 리팩토링
cc66ef0
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] AfterLogin logout 로직 리팩토링
0b392e0
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
♻️ :: [#477] RequestViewModel / logout 로직 리팩토링
c636436
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] IntroViewModel / 비로그인 상태에서는 인트로 상태에서 넘어갈 수 없어지는 로직 버그
593429c
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] 비로그인 상태일 시 userInfoResult에 성공 전달
bcf6f2f
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
🐛 :: [#477] NeedleGenerate
0973f42
baekteun added a commit that referenced this issue Apr 14, 2024
@baekteun
Merge pull request #488 from wakmusic/477-remove-keychain-direct-usag…
1fe0726 
…e-on-presentation-label

🔀 :: (#477) Feature 레이어에서의 keychain 직접 사용 코드 리팩토링
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baekteun baekteun

Labels
♻️ Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
1 participant
@baekteun