Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#477) Feature 레이어의 로그아웃 로직 리팩토링 #487

Merged
merged 8 commits into from
Apr 14, 2024
Merged

🔀 :: (#477) Feature 레이어의 로그아웃 로직 리팩토링 #487

merged 8 commits into from
Apr 14, 2024

Conversation

baekteun
Copy link
Member

💡 배경 및 개요

로그아웃을 처리하는 로직이 Presentation 영역에서 진행되었어요.

Resolves: #477

📃 작업내용

  • ContainSongs, MultiPurposePopup, PlayListDetail, ProfilePop, Player, Favorite, MyPlayList 페이지의 Logout 로직을 리팩토링했어요.
    • 도메인 로직에 해당하는 영역을 ViewModel이 하도록 옮겼어요.

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2024 •
edited
Loading

✅ Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

✅ 이슈와 PR의 Labels 동기화를 성공했어요!

@github-actions github-actions bot added the ♻️ Refactor 코드 리팩토링 label Apr 13, 2024
@baekteun baekteun force-pushed the 477-logout-usecase branch from f8659b3 to 564fc47 Compare April 14, 2024 05:05
Base automatically changed from 477-logout-usecase to develop April 14, 2024 05:08
@baekteun baekteun force-pushed the 477-logout-logic-refactoring branch from a1f6158 to 9631289 Compare April 14, 2024 05:09
@baekteun baekteun merged commit 2366efe into develop Apr 14, 2024
2 checks passed
@baekteun baekteun deleted the 477-logout-logic-refactoring branch April 14, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@baekteun baekteun

Labels
♻️ Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature레이어에서의 Keychain을 직접 사용 코드 리팩토링
4 participants
@baekteun @KangTaeHoon @yongbeomkwak @youn9k