Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protected-audience feature #2635

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 11, 2025

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 11, 2025
@captainbrosset
Copy link
Contributor

Protected Audience is part of Google's Privacy Sandbox project. Edge has a different proposal for this particular API, called the Ad Selection API.
See https://blogs.windows.com/msedgedev/2024/03/05/new-privacy-preserving-ads-api/ and https://blogs.windows.com/msedgedev/2024/10/08/ad-selection-api-limited-preview/

So the fact that BCD shows both Chrome and Edge as supporting Protected Audience feels wrong.
Edge generally mirrors Chrome by default, but this is one case where it probably shouldn't.

I'll try to find more information to (possibly) fix BCD.

@ddbeck ddbeck force-pushed the protected-audience branch from 12398f0 to f70718d Compare February 11, 2025 15:57
Comment on lines +4 to +5
status:
compute_from: api.Navigator.getInterestGroupAdAuctionData
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit awkward. It might be nice to unset this when Chrome 134 hits stable.

See also #2638 (comment)

@captainbrosset
Copy link
Contributor

Protected Audience is part of Google's Privacy Sandbox project. Edge has a different proposal for this particular API, called the Ad Selection API. See https://blogs.windows.com/msedgedev/2024/03/05/new-privacy-preserving-ads-api/ and https://blogs.windows.com/msedgedev/2024/10/08/ad-selection-api-limited-preview/

So the fact that BCD shows both Chrome and Edge as supporting Protected Audience feels wrong. Edge generally mirrors Chrome by default, but this is one case where it probably shouldn't.

This is more complicated than I thought. Chrome and Edge basically support the same individual BCD keys (with some exceptions), but the overall feature that these BCD keys contribute to isn't the same in Edge and in Chrome.
While Chrome calls it Protected Audience, Edge calls it Ad Selection API.

And there are some caveats, such as runAdAuction which Edge does support for completing server auctions, but not for local auctions.

@ddbeck
Copy link
Collaborator Author

ddbeck commented Feb 12, 2025

the overall feature that these BCD keys contribute to isn't the same in Edge and in Chrome

Hmm, that's a bit awkward.

I found this doc about the API shape to be helpful toward this but not sufficiently detailed. I think what I really need here are IDLs for the two APIs, so we can figure out what constitutes evidence of support for the two features. Even if the API surface is very similar, my hunch is that the difference is in configuration dictionaries that the BCD Collector won't detect (or rather won't do anything with by default).

This is likely to be a feature that really demands #1173.

@captainbrosset
Copy link
Contributor

I found this doc about the API shape to be helpful toward this but not sufficiently detailed.

Yes, that's the right doc.

I think what I really need here are IDLs for the two APIs, so we can figure out what constitutes evidence of support for the two features. Even if the API surface is very similar, my hunch is that the difference is in configuration dictionaries that the BCD Collector won't detect (or rather won't do anything with by default).

I've started an ms-internal discussion to try and help here. While the IDLs may be very similar (apart from the ProtectedAudience interface, which won't exist in Edge), I think they will work differently. For example, runAdAuction won't do exactly the same thing in Chrome and in Edge.

This is likely to be a feature that really demands #1173.

Definitely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants