shared-storage: assign more keys
#2638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
commented
Feb 11, 2025
Comment on lines
+5
to
+6
| status: | ||
| compute_from: api.SharedStorage.worklet |
There was a problem hiding this comment.
I think it'd be nice to unset this when Chrome 134 ships, since there's currently only one implementer for the whole feature. When another implementation happens, we can pick a more specific/useful compute_from value.
Elchi3
reviewed
Feb 12, 2025
There was a problem hiding this comment.
The alternative here would be to make a new feature "Web Locks integration with Shared Storage"
https://chromestatus.com/feature/5133950203461632
https://github.com/WICG/shared-storage?tab=readme-ov-file#locking-for-modifier-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.