Issue #546 - Navigate back in history from the back arrow on issue pa…

…ges. But only if that was the Referer.
webcompat · Feb 3, 2015 · ec2efbc · karlcow · Feb 4, 2015 · miketaylr
1 parent e2fc478
commit ec2efbc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/webcompat/static/js/lib/issues.js b/webcompat/static/js/lib/issues.js
@@ -15,13 +15,27 @@ marked.setOptions({
 
 issues.TitleView = Backbone.View.extend({
   el: $('.Issue-title'),
+  events: {
+    'click .js-linkBack': 'goBack'
+  },
   template: _.template($('#title-tmpl').html()),
   render: function() {
     document.title = "Issue " + this.model.get('number') +
                      ": " + this.model.get('title') +
                      " - webcompat.com";
     this.$el.html(this.template(this.model.toJSON()));
     return this;
+  },
+  goBack: function(e) {
+    if (!('origin' in location)) {
+      location.origin = location.protocol + '//' + location.host;
+    }
+
+    // Only go back in history if we came from the /issues page.
+    if (document.referrer.indexOf(location.origin + '/issues') === 0) {
+      history.back();
+      e.preventDefault();
+    }
   }
 });
 

diff --git a/webcompat/templates/issue.html b/webcompat/templates/issue.html
@@ -5,7 +5,7 @@
     <main class="wc-content wc-content--body Issue" role="main">
       <h1 class="Issue-title wc-Title--l">
       <script type="text/template" id="title-tmpl">
-        <a class="Issue-linkBack" href="{{ url_for("show_issues") }}" title="All issues">
+        <a class="Issue-linkBack js-linkBack" href="{{ url_for("show_issues") }}" title="All issues">
           <span class="wc-sronly">All Issues</span>
           <span class="Issue-linkBack-icon wc-Icon wc-Icon--arrow-left" aria-hidden="true"></span>
         </a>