Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow to go back from an issue after navigation #546

Closed
karlcow opened this issue Feb 3, 2015 · 3 comments
Closed

Arrow to go back from an issue after navigation #546

karlcow opened this issue Feb 3, 2015 · 3 comments
Assignees

Comments

@karlcow
Copy link
Member

karlcow commented Feb 3, 2015

Steps to reproduce.

  1. Go to http://webcompat.com/
  2. Click on New issues. We reach https://webcompat.com/issues?page=1&per_page=50&state=open&stage=new
  3. Click on an issue. We land to something like this:
    webcompat

What are your expectations with regards to the back arrow near the title of the issue. For me, it's mostly to come back to the step 2. The code is at:

<a class="Issue-linkBack" href="/issues" title="All issues">
          <span class="wc-sronly">All Issues</span>
          <span class="Issue-linkBack-icon wc-Icon wc-Icon--arrow-left" aria-hidden="true"></span>
        </a>

before we modify anything in the code. I wonder what are the expectations of others?

@tagawa
Copy link
Member

tagawa commented Feb 3, 2015

Good point @karlcow - I'd expect it to go back to the filtered list of issues rather than all issues.

@magsout
Copy link
Member

magsout commented Feb 3, 2015

Good point @karlcow - I'd expect it to go back to the filtered list of issues rather than all issues.

Yes, +1

@miketaylr
Copy link
Member

Yeah, let's see if we can call history.back() and prevent the default action on the link--in theory that should work.

@miketaylr miketaylr self-assigned this Feb 3, 2015
miketaylr pushed a commit that referenced this issue Feb 3, 2015
miketaylr pushed a commit that referenced this issue Feb 3, 2015
@karlcow karlcow closed this as completed in 080aa3f Feb 4, 2015
miketaylr pushed a commit that referenced this issue Feb 28, 2015
miketaylr pushed a commit that referenced this issue Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants