-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bug submit form #1547
Comments
@adamopenweb @miketaylr @karlcow anything I forgot in the todos (feel free to edit)? |
I added a "Update form validation in bugform.js" to the JS section, maybe there should be a "figure out what is optional/required" task as well? |
@miketaylr thanks. Also added the task. And thanks for the title edit. |
Added "Massaging the data before sending them to the issue template. The structure being slightly different." |
@karlcow thanks for the addition. could you make the todo a bit more specific as I am not sure what "massaging the data" means? 😁 Also just adding a comment here and linking it next to the todo works. Thanks! :) |
@zoepage creating the payload on the python side which is sent to GitHub. We have a form with multiple parameter which is creating a JSON payload that we are sending to GitHub. |
@karlcow thank you :) |
Hi all, I think that the last question in the form, "Did you test in another browser?" [Yes][No], should have at least 2 followup questions, if the answer is Yes: [Yes] --> (Q1) Which one? (drop down list - Edge, Safari, Chrome etc) --> (Q2) Is the same as in [field for "Firefox 52"]? [Yes][No] I think that if someone tries to reproduce an issue in another browser, will be ok with providing a little bit more information. |
Hi all, |
I think "how did you get there" should be a textarea, rather than input. It could even have placeholder text that mentions you can include any extra information, like @softvision-oana-arbuzov is suggestion. |
Here's a wild thought we had: |
The issue is the security risks suddenly increases a lot. We are not currently setup for this kind of things. Maybe there could be other ways of doing it. |
Yeah, zip can be scary. If we need to support videos, there are 3rd party solutions, or we can upload video assets directly to S3. Other than video, what would you like to include in a zip @softvision-sergiulogigan? |
I was thinking more of videos... But indeed, videos can be added afterwards, directly on Git (for non-anonymous users). |
@softvision-sergiulogigan @softvision-oana-arbuzov (also @miketaylr @karlcow @adamopenweb)
|
love the new design of every element form. The buttons are much clear. Super excited about the new design. Good job @zoepage |
Looks good! Can you explain the following, for the report as GitHub user?
|
@miketaylr this is the toggle between the labeling of the second button. The phrasing is misleading. When you are not logged in, you get the label "report as GitHub user". If you are "report as xyz". |
@adamopenweb suggested following for the
|
Last call for feedback on labeling and optional / required. After we decided, @cch5ng said she'd love to take over and take care of the first steps. :) |
My only concern is the placeholder text in #1547 (comment). It might be confusing as-is, it feels a bit like an instruction to a user, rather than an example. |
also validation updates and tests fix: #1547; update text area placeholder for steps to reproduce style: #1547; reduce text area height for desktop fix: #1547; move image upload link to steps text area fix: #1547; fix name changes for browser_test_type field; comment fix: #1552; stop enabling report button on image upload tests: #1547; fix for steps to reproduce data in url param fix: #1547; updates to make browser test radio buttons not required cleanup: #1547; update checkParams() remove functionality not used by tools fix: #1547; revert validation logic to use description field to check for problem type tests: #1547, removed test that would not be used by tool fix: #1547; content details fix: #1547; content details fix: #1547; fix broken test with categ type validation check tests: #1547; fix assertion to match current issue date; unsure how they got out of sync style: #1547; pep8 fixes fix: #1547; warning on travis about secrets.py.example file tests: #1547; reverted desc field test to original content: #1547; update supported format list content: #1547; update label tests: #1547; remove dupe test fix: #1547; remove secrets.py.example cleanup: #1547; prettier fixes style: #1547; prettier fixes tests: #1547; add back orig test for media type report tests: #1547; deselect description causes validation msg tests: #1547; prettier fixes tests: #1547; change selector to xpath to fix intermittent failures style: #1547; prettier fixes tests: #1547; removed xpath for cssselector, and try diff selector for test failing travis tests: #1547; revert test to pass on travis but results in expected failure locally fix: #1547; remove fix for #1552 fix: #1547; re add validation check required fix: #1547; review, update var, function names, remove problem_label fix: #1547; review, refactor radio button fields functions into one; add test style: #1547; pep8 fixes style: #1547; pep8 fix fix: #1547; review refactor and test update style: #1547; pep8 fix fix: #1547; replace hard coded html labels with python labels; grammar fix fix: #1547; revert hard coded label for problem type; fixes functional test expectation for field validation fix: #1547; revert old logic
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics tests: #1547; add required field validation test for Description input
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics tests: #1547; add required field validation test for Description input style: #1547; fix linting issues
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics tests: #1547; add required field validation test for Description input style: #1547; fix linting issues tests: #1547; try to place test failing on travis at top of list
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics tests: #1547; add required field validation test for Description input style: #1547; fix linting issues tests: #1547; try to place test failing on travis at top of list tests: #1547; remove test failing on travis Description error validation
… .wc-Form-validation style: #1547; pep8 fix: #1547; line format tests: #1547; remove comment per review tests: #1547; cleanup per review tests: #1547; fix typos content: #1547; add placeholder text to text area fix: #1547; update property name stepsToReproduceField fix: #1547; update label text and cleanup tests: #1547; fix broken test with selector update tests: #1547; add id for functional test selector fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency tests: #1547; update selectors for failing tests style: #1547; linting issues fix: #1547; update selector for test to .js-bug-form-os tests: #1547; remove description validation when move away required error displays, needs follow up with selector style: #1547; fix linting issues tests: #1547; update selector for text area fix: #1547; update text area placeholder and copyURL() function to work with existing functional test style: #1547; pep8 fix tests: #1547; remove test for copyURL() fix: #1547; remove copyURL() from js; revert text area placeholder text style: #1547; linting fix tests: #1547; add required field validation test for description input style: #1547; linting fixes tests: #1547; remove description error validation test b/c of broken selector on travis style: #1547; add space between label and required icon for consistency/aesthetics tests: #1547; add required field validation test for Description input style: #1547; fix linting issues tests: #1547; try to place test failing on travis at top of list tests: #1547; remove test failing on travis Description error validation style: #1547 and #1611; fix box shadow, add spacing, update text area
Fixes #1547 - new bug form content refactor
Context
-> https://webcompat.com/issues/new & https://webcompat.com/?open=1
More Context: #1007 (comment) (please see the work week notes in the details)
NOTE: There will NOT be a redesign yet as seen in the mockups. We aim to change the form structure first as well as the wording of the labels. :)
Todos
Text
HTML/CSS
Describe what was wrong?
andHow did you get there?
as replacement forExpected behavior
andActual behavior
Is this information correct?
Did you test in another browser?
label and two radio buttons with [yes/no] options.TESTS
API/PYTHON/JS
Did you test in another browser?
radio buttonsMockups
Desktop
Mobile
The text was updated successfully, but these errors were encountered: