Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bug submit form #1547

Closed
12 of 14 tasks
zoepage opened this issue May 2, 2017 · 46 comments
Closed
12 of 14 tasks

Refactor bug submit form #1547

zoepage opened this issue May 2, 2017 · 46 comments

Comments

@zoepage
Copy link
Member

zoepage commented May 2, 2017

Context

-> https://webcompat.com/issues/new & https://webcompat.com/?open=1

More Context: #1007 (comment) (please see the work week notes in the details)

NOTE: There will NOT be a redesign yet as seen in the mockups. We aim to change the form structure first as well as the wording of the labels. :)

Todos

Text

HTML/CSS

  • Switch upper grid cells in the form (as seen in mockups)
  • Split textarea in two different input fields. Add Describe what was wrong? and How did you get there? as replacement for Expected behavior and Actual behavior
  • Group inputs for browser / OS version
  • Change label of browser / OS version to Is this information correct?
  • Add Did you test in another browser? label and two radio buttons with [yes/no] options.
  • Make new form information readable in issue template (https://github.com/webcompat/webcompat.com/blob/master/webcompat/templates/issue.html)

TESTS

API/PYTHON/JS

  • Add fields for Did you test in another browser? radio buttons
  • Change textarea -> two input fields and store information
  • Massaging the data before sending them to the issue template. The structure being slightly different. (Refactor bug submit form #1547 (comment))
  • Update form validation in bugform.js

Mockups

Desktop
desktop hd

Mobile
mobile portrait

@zoepage
Copy link
Member Author

zoepage commented May 2, 2017

@adamopenweb @miketaylr @karlcow anything I forgot in the todos (feel free to edit)?

@miketaylr miketaylr changed the title Refactor bug sumbit form Refactor bug submit form May 2, 2017
@miketaylr
Copy link
Member

I added a "Update form validation in bugform.js" to the JS section, maybe there should be a "figure out what is optional/required" task as well?

@zoepage
Copy link
Member Author

zoepage commented May 2, 2017

@miketaylr thanks. Also added the task. And thanks for the title edit.
(Reminder to myself: Don't write issues before any coffee.)

@karlcow
Copy link
Member

karlcow commented May 2, 2017

Added "Massaging the data before sending them to the issue template. The structure being slightly different."

@zoepage
Copy link
Member Author

zoepage commented May 3, 2017

@karlcow thanks for the addition. could you make the todo a bit more specific as I am not sure what "massaging the data" means? 😁 Also just adding a comment here and linking it next to the todo works. Thanks! :)

@karlcow
Copy link
Member

karlcow commented May 3, 2017

@zoepage creating the payload on the python side which is sent to GitHub. We have a form with multiple parameter which is creating a JSON payload that we are sending to GitHub.
See https://github.com/webcompat/webcompat.com/blob/master/webcompat/form.py#L161

@zoepage
Copy link
Member Author

zoepage commented May 3, 2017

@karlcow thank you :)

@softvision-sergiulogigan
Copy link
Collaborator

Hi all,

I think that the last question in the form, "Did you test in another browser?" [Yes][No], should have at least 2 followup questions, if the answer is Yes:

[Yes] --> (Q1) Which one? (drop down list - Edge, Safari, Chrome etc) --> (Q2) Is the same as in [field for "Firefox 52"]? [Yes][No]

I think that if someone tries to reproduce an issue in another browser, will be ok with providing a little bit more information.

@softvision-oana-arbuzov
Copy link
Member

Hi all,
I think a "Notes" text area would be nice to have, in case extra info is available (debugging/reproducibility rate...).

@miketaylr
Copy link
Member

I think "how did you get there" should be a textarea, rather than input. It could even have placeholder text that mentions you can include any extra information, like @softvision-oana-arbuzov is suggestion.

@softvision-sergiulogigan
Copy link
Collaborator

Here's a wild thought we had:
What if the Screenshot placeholder would support *.zip files as well?
1st of all, this would help us filing issues more efficiently, but we think other reporters would like to attach not only screenshots, but also short videos of encountered issues (maybe of those that are harder to explain).

@karlcow
Copy link
Member

karlcow commented May 5, 2017

@softvision-sergiulogigan

What if the Screenshot placeholder would support *.zip files as well?

The issue is the security risks suddenly increases a lot. We are not currently setup for this kind of things. Maybe there could be other ways of doing it.

@miketaylr
Copy link
Member

Yeah, zip can be scary. If we need to support videos, there are 3rd party solutions, or we can upload video assets directly to S3.

Other than video, what would you like to include in a zip @softvision-sergiulogigan?

@softvision-sergiulogigan
Copy link
Collaborator

I was thinking more of videos... But indeed, videos can be added afterwards, directly on Git (for non-anonymous users).

@zoepage
Copy link
Member Author

zoepage commented May 14, 2017

@softvision-sergiulogigan @softvision-oana-arbuzov
Thank you for your suggestions! As we decided during the work week to stick with a small set of changes, I will add them to the next steps in combination with the refactor.

(also @miketaylr @karlcow @adamopenweb)
To cross off the first 2 todo's, here is a final suggestion for the form.

  • = required
  - Site URL* // label + input
      - e.g. https://example.com 
      
  - Type of bug* // fieldset -> label + radio + labels
      - Desktop site instead of mobile site 
      - Site is not usable 
      - Design is broken 
      - Video or audio doesn't play
      - Something else
      
  - Please describe what was wrong.* // label + input
    - e.g. The video should have started after 3 sec.
    
  - How did you get there? // label + textarea
    - 1. Log in
      2. Fill out form details
      3. Click submit
    
  - Is this information correct? // label + 2 input's (inputs get a checkmark if prepolluted with correct info. correct as in found user agent. we need a check here for UA and OS.) 
    - Browser version 
    - OS 
    
  - Did you test in another browser? // label + 2 radio's (don't pre-select)
    - Yes
    - No
    
  - Screenshot upload // label + input
  - report anonymously // button 
  - report as GitHub user (/report as xyz) // button, just show if logged in
  

@magsout
Copy link
Member

magsout commented May 14, 2017

love the new design of every element form. The buttons are much clear.

Super excited about the new design.

Good job @zoepage

@miketaylr
Copy link
Member

Looks good!

Can you explain the following, for the report as GitHub user?

button, just show if logged in

@zoepage
Copy link
Member Author

zoepage commented May 16, 2017

@miketaylr this is the toggle between the labeling of the second button. The phrasing is misleading.

When you are not logged in, you get the label "report as GitHub user". If you are "report as xyz".

@zoepage
Copy link
Member Author

zoepage commented May 16, 2017

@adamopenweb suggested following for the How did you get there? textarea:

1. Log in
2. Fill out form details
3. Click submit

@zoepage
Copy link
Member Author

zoepage commented May 16, 2017

Last call for feedback on labeling and optional / required. After we decided, @cch5ng said she'd love to take over and take care of the first steps. :)

@karlcow @miketaylr @adamopenweb

@miketaylr
Copy link
Member

My only concern is the placeholder text in #1547 (comment). It might be confusing as-is, it feels a bit like an instruction to a user, rather than an example.

cch5ng added a commit that referenced this issue Jun 10, 2017
cch5ng added a commit that referenced this issue Jun 12, 2017
also validation updates and tests

fix: #1547; update text area placeholder for steps to reproduce

style: #1547; reduce text area height for desktop

fix: #1547; move image upload link to steps text area

fix: #1547; fix name changes for browser_test_type field; comment

fix: #1552; stop enabling report button on image upload

tests: #1547; fix for steps to reproduce data in url param

fix: #1547; updates to make browser test radio buttons not required

cleanup: #1547; update checkParams() remove functionality not used by tools

fix: #1547; revert validation logic to use description field to check for problem type

tests: #1547, removed test that would not be used by tool

fix: #1547; content details

fix: #1547; content details

fix: #1547; fix broken test with categ type validation check

tests: #1547; fix assertion to match current issue date; unsure how they got out of sync

style: #1547; pep8 fixes

fix: #1547; warning on travis about secrets.py.example file

tests: #1547; reverted desc field test to original

content: #1547; update supported format list

content: #1547; update label

tests: #1547; remove dupe test

fix: #1547; remove secrets.py.example

cleanup: #1547; prettier fixes

style: #1547; prettier fixes

tests: #1547; add back orig test for media type report

tests: #1547; deselect description causes validation msg

tests: #1547; prettier fixes

tests: #1547; change selector to xpath to fix intermittent failures

style: #1547; prettier fixes

tests: #1547; removed xpath for cssselector, and try diff selector for test failing travis

tests: #1547; revert test to pass on travis but results in expected failure locally

fix: #1547; remove fix for #1552

fix: #1547; re add validation check required

fix: #1547; review, update var, function names, remove problem_label

fix: #1547; review, refactor radio button fields functions into one; add test

style: #1547; pep8 fixes

style: #1547; pep8 fix

fix: #1547; review refactor and test update

style: #1547; pep8 fix

fix: #1547; replace hard coded html labels with python labels; grammar fix

fix: #1547; revert hard coded label for problem type; fixes functional test expectation for field validation

fix: #1547; revert old logic
cch5ng added a commit that referenced this issue Jun 12, 2017
cch5ng added a commit that referenced this issue Jun 20, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes
cch5ng added a commit that referenced this issue Jun 21, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis
cch5ng added a commit that referenced this issue Jun 22, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics
cch5ng added a commit that referenced this issue Jun 22, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics

tests: #1547; add required field validation test for Description input
cch5ng added a commit that referenced this issue Jun 22, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics

tests: #1547; add required field validation test for Description input

style: #1547; fix linting issues
cch5ng added a commit that referenced this issue Jun 22, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics

tests: #1547; add required field validation test for Description input

style: #1547; fix linting issues

tests: #1547; try to place test failing on travis at top of list
cch5ng added a commit that referenced this issue Jun 22, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics

tests: #1547; add required field validation test for Description input

style: #1547; fix linting issues

tests: #1547; try to place test failing on travis at top of list

tests: #1547; remove test failing on travis Description error validation
cch5ng added a commit that referenced this issue Jun 27, 2017
… .wc-Form-validation

style: #1547; pep8

fix: #1547; line format

tests: #1547; remove comment per review

tests: #1547; cleanup per review

tests: #1547; fix typos

content: #1547; add placeholder text to text area

fix: #1547; update property name stepsToReproduceField

fix: #1547; update label text and cleanup

tests: #1547; fix broken test with selector update

tests: #1547; add id for functional test selector

fix: #1547; revert radio button value to "video_bug" because of media type report tool dependency

tests: #1547; update selectors for failing tests

style: #1547; linting issues

fix: #1547; update selector for test to .js-bug-form-os

tests: #1547; remove description validation when move away required error displays, needs follow up with selector

style: #1547; fix linting issues

tests: #1547; update selector for text area

fix: #1547; update text area placeholder and copyURL() function to work with existing functional test

style: #1547; pep8 fix

tests: #1547; remove test for copyURL()

fix: #1547; remove copyURL() from js; revert text area placeholder text

style: #1547; linting fix

tests: #1547; add required field validation test for description input

style: #1547; linting fixes

tests: #1547; remove description error validation test b/c of broken selector on travis

style: #1547; add space between label and required icon for consistency/aesthetics

tests: #1547; add required field validation test for Description input

style: #1547; fix linting issues

tests: #1547; try to place test failing on travis at top of list

tests: #1547; remove test failing on travis Description error validation

style: #1547 and #1611; fix box shadow, add spacing, update text area
miketaylr pushed a commit that referenced this issue Jun 29, 2017
Fixes #1547 - new bug form content refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment