Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji in markdown for specific patterns should be avoided #1297

Closed
karlcow opened this issue Jan 23, 2017 · 6 comments
Closed

Emoji in markdown for specific patterns should be avoided #1297

karlcow opened this issue Jan 23, 2017 · 6 comments

Comments

@karlcow
Copy link
Member

karlcow commented Jan 23, 2017

This is happening in https://webcompat.com/issues/4313
When a user is typing a character in a form which is just after : without leaving a space. The converter will interpret it as an emoji. Some strings should be out of parsing because there are part of the system. Expected behavior: Should not be parsed for emojis.

capture d ecran 2017-01-23 a 11 22 16

@miketaylr
Copy link
Member

😛

@zoepage
Copy link
Member

zoepage commented Jan 25, 2017

@karlcow it might be enough to add a space after the :?
Could be a good quick fix before we redo the form.

(Disabling emoji rendering is tricky. Parsing the message maybe overhead?)

@miketaylr
Copy link
Member

@karlcow it might be enough to add a space after the :?

That might work as a quick hack.

If we do move to a form with multiple textareas for expected/actual behavior (as has been suggested in a few issues), we can also avoid this problem by adding the expected/actual behavior headings to the user input ourselves, once they're submitted to the back-end.

But I agree we probably want some way to tell the emoji lib, don't look at these strings.

@zoepage
Copy link
Member

zoepage commented Apr 3, 2017

This and #1171 and #613 could be probably fixed in one solution, when we parse the message and check for specific pointers?

@cch5ng
Copy link
Contributor

cch5ng commented Jun 28, 2017

hi, I'm starting to look at this bug. after #1547 gets merged, the text area placeholder will no longer contain ":". ie it has changed to:

For example,

  1. I've tried to log in.
  2. I've filled out the form details.
  3. I clicked on the submit button.
  4. Nothing happened.

does this mean this issue could be closed or should it still be fixed?

@karlcow
Copy link
Member Author

karlcow commented Sep 26, 2018

Another instance in webcompat/web-bugs#19090
https://webcompat.com/issues/19090

GitHub has the same bug.
capture d ecran 2018-09-26 a 14 19 38

@karlcow karlcow added this to the Paris October 2018 milestone Sep 26, 2018
@miketaylr miketaylr removed this from the Paris October 2018 milestone Sep 30, 2018
@magsout magsout closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants