Fixes #3041 - Use Operating System instead of Device #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: it seems like FormWizard.device wasn't even used -- it was populated but never sent to GitHub. It was sending FormWizard.os all along.
karlcow
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
That was introduced in dcae9aa#diff-f1975977b06efb529b8c60f23a7bc4eeR237
note that device would be useful for #997
but that's a separate discussion.
Thanks for cleaning up @miketaylr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it seems like FormWizard.device wasn't even used -- it was populated
but never sent to GitHub. It was sending FormWizard.os all along.
I've tested that filing a bug still works, just to be safe.