Fixes #432 - Give common problem types as a choice for the user #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and use named arguments in the description of build_formdata)
[ci skip]
|
👍 lgtm..I just have to change some parts of the css, but one can merge before. |
| @@ -16,18 +16,22 @@ | |||
| from wtforms import TextAreaField | |||
| from wtforms.validators import Length | |||
| from wtforms.validators import Optional | |||
| from wtforms.validators import Required | |||
| from wtforms.validators import InputRequired | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
The python looks good. 👍 Just fix the small things and automatic r+ after this. |
|
Okey doke, let's pull the trigger. 🔫 |
miketaylr
pushed a commit
that referenced
this pull request
Mar 9, 2015
Fixes #432 - Give common problem types as a choice for the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed this to https://staging.webcompat.com so you can see it live and report test bugs, etc.
r? @magsout for CSS/HTML/JS bits.
r? @karlcow for Python bits.