Refactoring class for new form report #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and use named arguments in the description of build_formdata)
[ci skip]
|
Heh, think I just made it messier. |
|
I'm gonna close this and open a new one when I fix the failing test. |
|
My bad. I didn't know in this case what was the better way ? Push in your branch or create another branch and Make a PR ? |
|
I think pushing to the same branch would have been fine. But it's not a big deal--more important is the awesome CSS work you did, not the process of getting it merged. :) |
ok, good to know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged after #579
But maybe before, rebase ...
r? @miketaylr