Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize Content and Routing Structure #1153

Closed
wants to merge 13 commits into from

Conversation

skipjack
Copy link
Collaborator

@skipjack skipjack commented Apr 25, 2017

Still a WIP...

Currently our /content directory doesn't exactly reflect our routing structure. This is an attempt to fix that and clean up a variety of other oddities and hacks related to content and routing. It won't be a perfect fix, as there are a few antwar tickets open that would allow us to simplify things even further and add other functionality like the fully dynamic routing/content structure proposed here but it will take us one step closer to that so things are easier to migrate later on.

Here are the things I'd like to accomplish with this PR:

  • Rebase on master once Port to webpack 3 and Upgrade Antwar #980 is finished
  • Synchronize content and routing structure... the big one being nesting api, configuration, development, loaders, and plugins all under a new /documentation route.
  • Update all internal links broken by the above change.
  • Add redirects for all external links that would be broken by the above change.
  • Update navigation links both in the Navigation and SidebarMobile components... the mobile sidebar is probably in the worse state of these two as some links are just blank. I'm hoping to achieve a more dynamic result but this is another one that will be facilitated by certain antwar updates like Reflect Content Structure in Routing Structure antwarjs/antwar#124.
  • Add link to new starter-kits guide which is still hidden.

This will take some serious review when finished as it is a major change to the site. However it will knock out some things from #1039 and should provide a more intuitive layout for future (and present) contributors.

@skipjack
Copy link
Collaborator Author

skipjack commented Apr 29, 2017

Pretty much just the edit and generated links failing now... the edit ones should be fixed by a build and, for generated, shouldn't they be the full urls anyway as those readmes exist separately?

I'm going to start on the UI work and redirects.

@skipjack skipjack force-pushed the sync-structure-n-routing branch from 296dad6 to c34eba0 Compare May 8, 2017 22:47
@skipjack
Copy link
Collaborator Author

skipjack commented Jul 2, 2017

Closing as this has become fairly dated and I'm not sure when #980 will be completed -- I'll either re-open or make similar changes down the road.

@skipjack skipjack closed this Jul 2, 2017
@skipjack skipjack deleted the sync-structure-n-routing branch September 30, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant