-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize Content and Routing Structure #1153
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty much just the edit and generated links failing now... the edit ones should be fixed by a build and, for generated, shouldn't they be the full urls anyway as those readmes exist separately? I'm going to start on the UI work and redirects. |
This was referenced May 7, 2017
…le/parameter names
skipjack
force-pushed
the
sync-structure-n-routing
branch
from
May 8, 2017 22:47
296dad6
to
c34eba0
Compare
Merged
Closing as this has become fairly dated and I'm not sure when #980 will be completed -- I'll either re-open or make similar changes down the road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP...
Currently our
/content
directory doesn't exactly reflect our routing structure. This is an attempt to fix that and clean up a variety of other oddities and hacks related to content and routing. It won't be a perfect fix, as there are a few antwar tickets open that would allow us to simplify things even further and add other functionality like the fully dynamic routing/content structure proposed here but it will take us one step closer to that so things are easier to migrate later on.Here are the things I'd like to accomplish with this PR:
/documentation
route.Navigation
andSidebarMobile
components... the mobile sidebar is probably in the worse state of these two as some links are just blank. I'm hoping to achieve a more dynamic result but this is another one that will be facilitated by certain antwar updates like Reflect Content Structure in Routing Structure antwarjs/antwar#124.This will take some serious review when finished as it is a major change to the site. However it will knock out some things from #1039 and should provide a more intuitive layout for future (and present) contributors.