Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter Kits #1253

Merged
merged 9 commits into from
May 27, 2017
Merged

Starter Kits #1253

merged 9 commits into from
May 27, 2017

Conversation

skipjack
Copy link
Collaborator

@skipjack skipjack commented May 27, 2017

Adds a starter kits guide fetched from @ahfarmer's tool-list package. Just working on a better display for the tags column and then this should be good to go.

Resolves #45

@skipjack skipjack requested a review from bebraw May 27, 2017 15:03
// those used in the markdown utility. Ideally we will soon create
// a table component that both the markdown utility and this page
// can use. This component could even use something like griddle
// to allow sorting and such.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want something super light, it's enough to attach a little standalone script (these exist for sure) that hooks into the table.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to hold off on anything table related until we get a better markdown solution in place. I think the best option by far is to pipe all markdown to components that contain clean, isolated logic. It just feels like we've added a lot of features at this point, many of them in a hacky way which have come back to bite us.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

</div>
<div className="table-td">
<div className="table-td-title">Tags</div>
<div className="table-td-content">{ kit.tags.join(' | ') }</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok. Maybe better as separate elements with some nice class, though?

skipjack added 4 commits May 27, 2017 11:38
These looked pretty rough, and I've heard some people who were
confused whether the icon was part of the content. If anything we
should use more prominent, nice icons like the ones @pastelsky
showed in his mockups.
@skipjack
Copy link
Collaborator Author

Mobile:

image

Normal:

image

@bebraw
Copy link
Contributor

bebraw commented May 27, 2017

Looks good enough. 👍

@skipjack skipjack merged commit e66095f into master May 27, 2017
@skipjack skipjack deleted the starter-kits branch May 27, 2017 20:06
@skipjack
Copy link
Collaborator Author

Another one down, we just need to remember to add the link to this page in the sidebar. I'll add a todo for that in #1153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants