-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in "verbose" mode #31
base: master
Are you sure you want to change the base?
Conversation
Yes that would be better, because now does only hardcoded console.log() |
This PR also contains renaming of package, bin and what not. Ideally verbose mode should be locked behind a |
Right, @3rd-Eden. I was just about to ask, @truhlikfredy, would you be willing to add the flag and remove all the other changes? |
I didn't initiated the PR (i think my fork is not good enough in this stage for merge). The changes made there are very crude and dirty. Renamed the package so it will not overwrite the original when original behavior is needed. |
I'm -1 on these changes. I think there is no real value in printing the flag objects. |
This brings up an interesting question, though: What is the expected behavior for binary data? |
I think that if the wsConsole.print(`< ${buf.toString('hex')}`); Something like this, beautified if necessary. It probably wasn't designed to deal with binary messages. What other tools do in this case? |
@truhlikfredy, what do you think about adding a command-line flag for verbosity?