Add support for hexadecimal input/output #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can you resolve the conflicts and I'll merge it? |
FGasper
pushed a commit
to FGasper/wscat
that referenced
this pull request
May 12, 2019
* WebSocket subprotocol * Subprotocol help * Sort subprotocol keys * ICLIOptions fix * Update Makefile * Update Makefile * Fix IOptions
|
You will try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two options:
--hex-inand--hex-out.If
--hex-inis set, input is interpreted as space-separated bytes. E.g.,6a 61 7a 7a 70 69is interpreted asjazzpi.If
--hex-outis set, anything coming in to the websocket is printed as space-separated bytes. E.g., if wscat is running in--listen-mode and a client sendsjazzpi, it's printed out as6a 61 7a 7a 70 69.Note: I'm not quite sure about the internals of
ws, so I just was cautious and implemented Hex conversion forBuffers,ArrayBuffers andstrings (see lines 177-198).