Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deploying package #23

Merged
merged 3 commits into from
Dec 15, 2017
Merged

Replace deploying package #23

merged 3 commits into from
Dec 15, 2017

Conversation

tomasmcm
Copy link
Member

gulp-gh-pages is not working at the moment. Instead of adding more patches like we were it is best to replace it with a working alternative.
Enters gh-pages package, as suggested here https://github.com/shinnn/gulp-gh-pages/issues/43

@renatodeleao
Copy link
Collaborator

i'm aware of the problem with the package, but i've been using the deploy script with no problem. But it's a hack and probably just works on my node/npm version env.

This looks way more elegant, no doubt. :shipit:

@renatodeleao
Copy link
Collaborator

i'm merging this without testing 😱 as I have no time today, but I trust more on you than me.

@renatodeleao renatodeleao merged commit 218c4ec into master Dec 15, 2017
@renatodeleao renatodeleao deleted the replace-deploying-package branch December 15, 2017 11:08
@tomasmcm
Copy link
Member Author

my error was related to the wrap-promise package... so instead of adding another hack...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants