fix(astro): always return cloned content collection #11228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b19eb77 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
sarah11918
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Congrats on your first core PR @ascorbic ! 🥳
Might as well start you off on the right foot! Just made a small suggestion to the changeset for your consideration to give you a taste of what you're gonna get from me going forward... 😄
Welcome to core! 💜
matthewp
approved these changes
Jun 10, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
ascorbic
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the first time
getCollectionis called in prod it returns the same array that is then cached, meaning that any mutations are applied to the cached value. Subsequent calls return a clone of the cached value (so these can be safely changed), but any changes made on the first call are still present. The original bug was fixed in #8022, but it missed the issue with the first invocation. This PR ensures that the array is always cloned before returning.Fixes #10700
Testing
Adds a test fixture based on the #10700 repro. Thanks @SStembridge.
Docs