Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getCollection return new instance in prod #8022

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 10, 2023

Changes

Fixes withastro/roadmap#604

This was planned for 3.0, but I'm not sure if we need to, since the bug only happen in prod. For now I'm pointing this to merge into main.

Testing

Added a new test.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 1c3ae14

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 10, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad you figured out this was a dev/prod inconsistency and can change on a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants