Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: portfolio example JSX error #3886

Merged
merged 3 commits into from
Jul 11, 2022
+7 −2
Merged

fix: portfolio example JSX error #3886

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a5336d
fix: portfolio example JSX error
QuiiBz Jul 10, 2022
752382b
chore: add changeset
QuiiBz Jul 10, 2022
2833719
chore: update description
QuiiBz Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-points-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

Fix portfolio example JSX error
2 changes: 1 addition & 1 deletion examples/portfolio/src/pages/projects.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const projects = (await Astro.glob("./project/**/*.md"))
s
most
recent
projects'
projects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this must have happened in #3862!

Would you mind updating the description attribute so that it says:

description="Learn about Jeanine White's most recent projects"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, introduced here: https://github.com/withastro/astro/pull/3862/files#diff-a739195a828a765d1e4de3a8e8bf4622ea9b80dc79ac379432843fcc5447a946R23

I've updated the description!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, totally missed this in my review of that PR, my apologies!

/>
<style lang="scss">
.grid {
Expand Down