Skip cloudflare CLI tests if fail to start #8417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: integration
bluwy
commented
Sep 5, 2023
| cli = await runCLI('./fixtures/cf/', { silent: false, port: 8788 }); | ||
| await cli.ready; | ||
| cli = await runCLI('./fixtures/cf/', { silent: true, port: 8786 }); |
There was a problem hiding this comment.
Changed the port number as it's close to the other test's 8789 port, which maybe was causing issues somehow.
Princesseuh
approved these changes
Sep 5, 2023
natemoo-re
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cc @Princesseuh
I tried to use retries, but Mocha doesn't support it in the
beforehook. Implementing retries manually is also tricky, so I went with this PR instead - Try to run the test as usual, but if startup fails, skip the test suite.Testing
Ran the cloudflare tests locally. I've not seen it fail locally though.
Docs
n/a.