Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cloudflare CLI tests if fail to start #8417

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Skip cloudflare CLI tests if fail to start #8417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b9979d
Skip cloudflare CLI tests if fail to start
bluwy Sep 5, 2023
fcc54f5
Fix port
bluwy Sep 5, 2023
06aebf2
Merge branch 'main' into skip-cf-if-fail
natemoo-re Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/integrations/cloudflare/test/basics.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@ describe('Basic app', () => {
/** @type {import('./test-utils').WranglerCLI} */
let cli;

before(async () => {
before(async function () {
fixture = await loadFixture({
root: './fixtures/basics/',
});
await fixture.build();

cli = await runCLI('./fixtures/basics/', { silent: true, port: 8789 });
await cli.ready;
await cli.ready.catch((e) => {
console.log(e);
// if fail to start, skip for now as it's very flaky
this.skip();
});
});

after(async () => {
Expand Down
12 changes: 8 additions & 4 deletions packages/integrations/cloudflare/test/cf.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,28 @@ describe('Cf metadata and caches', () => {
/** @type {import('./test-utils').WranglerCLI} */
let cli;

before(async () => {
before(async function () {
fixture = await loadFixture({
root: './fixtures/cf/',
output: 'server',
adapter: cloudflare(),
});
await fixture.build();

cli = await runCLI('./fixtures/cf/', { silent: false, port: 8788 });
await cli.ready;
cli = await runCLI('./fixtures/cf/', { silent: true, port: 8786 });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the port number as it's close to the other test's 8789 port, which maybe was causing issues somehow.

await cli.ready.catch((e) => {
console.log(e);
// if fail to start, skip for now as it's very flaky
this.skip();
});
});

after(async () => {
await cli.stop();
});

it('Load cf and caches API', async () => {
let res = await fetch(`http://127.0.0.1:8788/`);
let res = await fetch(`http://127.0.0.1:8786/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
Expand Down
8 changes: 6 additions & 2 deletions packages/integrations/cloudflare/test/runtime.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ describe('Runtime Locals', () => {
/** @type {import('./test-utils.js').WranglerCLI} */
let cli;

before(async () => {
before(async function () {
fixture = await loadFixture({
root: './fixtures/runtime/',
output: 'server',
Expand All @@ -18,7 +18,11 @@ describe('Runtime Locals', () => {
await fixture.build();

cli = await runCLI('./fixtures/runtime/', { silent: true, port: 8793 });
await cli.ready;
await cli.ready.catch((e) => {
console.log(e);
// if fail to start, skip for now as it's very flaky
this.skip();
});
});

after(async () => {
Expand Down
8 changes: 6 additions & 2 deletions packages/integrations/cloudflare/test/with-solid-js.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@ describe('With SolidJS', () => {
/** @type {import('./test-utils').WranglerCLI} */
let cli;

before(async () => {
before(async function () {
fixture = await loadFixture({
root: './fixtures/with-solid-js/',
});
await fixture.build();

cli = await runCLI('./fixtures/with-solid-js/', { silent: true, port: 8790 });
await cli.ready;
await cli.ready.catch((e) => {
console.log(e);
// if fail to start, skip for now as it's very flaky
this.skip();
});
});

after(async () => {
Expand Down
Loading