-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a11y.ts #9507
Update a11y.ts #9507
Conversation
Update a11y-missing-content rule
|
After researching deeper to answer the question about I also realized that previously it was only going to check if the element that the I did test this by editing my node_modules on a local repo fwiw but if someone can verify it all works that would probably be best 😅 more reference: https://www.w3.org/TR/accname/#dfn-accessible-name |
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
add svg title check, as well as verified this rule aligns with deque and with voiceover formatted and fix a little ts issue as well
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
instead of using .some() method for the arialabelledby checks use a for loop just like the other checks
Tried to improve readability, as well as return early as @fflaten suggested. Also changed the error message. |
Allow for aria-label and aria-labelledby in a11y-missing-content rule
Changes
What does this change?
Don't forget a changeset!
pnpm exec changeset
Testing
unfamiliar with testing honestly, sorry in advance
Docs
docs update unnecessary