Update a11y.ts #9567
Update a11y.ts #9567
Conversation
…alt and svg title
🦋 Changeset detectedLatest commit: 41024d0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
There was a problem hiding this comment.
The fix looks good to me, although it seems that the rule doesn't check for missing alt for input tag with type image, for example.
Should this be implemented in this PR or another? Here's a reference: https://biomejs.dev/linter/rules/use-alt-text/
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
…1y.ts Co-authored-by: Emanuele Stoppa <[email protected]>
Good catch didn't even think about inputs although I don't know why someone would have a |
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
| message: 'Headings and anchors must have content to be accessible.', | ||
| title: 'Missing content', | ||
| message: | ||
| 'Headings and anchors must have an accessible name, which can come from: inner text, aria-label, aria-labelledby, an img with alt property, or an svg with a tag <title></title>.', |
There was a problem hiding this comment.
Just checking because I don't think these error messages currently get pulled into docs, so this should be fine. But for docs, we would be using back ticks for inline code formatting on all values, but especially any components like <title> or else docs will break.
@Princesseuh - tangentially, do we want these dev tool error messages available in docs somewhere? Eventually? We don't really have any "using dev toolbar" docs at all. Is this something we want/care about?
There was a problem hiding this comment.
Sorry, missed this message (blame GitHub notifications not working properly since a few weeks 😠). Yes, eventually I would like to have the audits in the docs, similar to the error reference.
It would most likely use JSDoc comments like the error reference do, so the messages would get sanitized etc. (or we'd duplicate every error in the docs, that's ok too)
Co-authored-by: Sarah Rainsberger <[email protected]>
Accidentally deleted PR #9507
Closes Issue #9551
Changes
Testing
Manually tested with @examples/blog
Docs