Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to broadcast a transaction: minimum relay fee not met #1322

Open
nondiremanuel opened this issue Sep 11, 2024 · 2 comments
Open

Fail to broadcast a transaction: minimum relay fee not met #1322

nondiremanuel opened this issue Sep 11, 2024 · 2 comments
Assignees
@jp1ac4
Labels
Bug Something isn't working as expected
Milestone
v10 Liana - UI fi...

Comments

@nondiremanuel
Copy link
Collaborator

During the last phase of tests, there was an occurrence of not being able to relay a transaction because the minimum fee was not met.

image

Since it is not clear where the rounding/estimation issue comes from (not clear if #1132 or else), we agreed that if after a quick further investigation the origin is still unknown, we will go with a temporary patch for v7, i.e. either using 1.1 sats/vb as a multiplier when 1 sats/vb is selected or adding 10 sats to the total fee amount if 1 sats/vb was selected. This should give some margin (at a small cost) to avoid that the user is not able to relay the transaction. In such case, a more detailed fix would then be released in a followup.
@nondiremanuel nondiremanuel moved this to Todo in Liana General Sep 11, 2024
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Sep 11, 2024
@jp1ac4 jp1ac4 mentioned this issue Sep 11, 2024
Merged
darosior added a commit that referenced this issue Sep 12, 2024
@darosior
Merge #1323: spend: ensure fee above min relay value
b2da2b7 
74a53ba spend: add 10 sats to fee for 1 sat/vb txs (Michael Mallan)

Pull request description:

  This is a quick change to address #1322.

  It adds 10 sats to the fee for a non-replacement transaction targeted at 1 sat/vb.

ACKs for top commit:
  darosior:
    utACK 74a53ba. Looking forward to a real fix.

Tree-SHA512: c8ef2a49be67b94c2198a246a82f92f16661308151540197a7831a06e1eca277fa3dafe733b53a97dc3c9fc6639f4b724237863f186e4ffeb0bf61c74a1e9c0b
@darosior darosior moved this from In Review to Done in Liana General Sep 12, 2024
@darosior
Copy link
Member

Marking as done for v7 since a temporary hack has been applied for this release in #1323. But leaving open as we should pin down the root cause of this issue.

@nondiremanuel nondiremanuel modified the milestones: v7 - Liana, v8 - Liana Sep 12, 2024
@nondiremanuel nondiremanuel moved this from Done to To be discussed / defined in Liana General Sep 12, 2024
@nondiremanuel
Copy link
Collaborator Author

Thanks. I moved it to v8 so that we don't loose track of it and it still counts as "done" for v7.

@nondiremanuel nondiremanuel added the Bug Something isn't working as expected label Sep 16, 2024
@jp1ac4 jp1ac4 mentioned this issue Oct 9, 2024
Open
@jp1ac4 jp1ac4 mentioned this issue Nov 8, 2024
Merged
@nondiremanuel nondiremanuel moved this from To be discussed / defined to In Review in Liana General Nov 12, 2024
edouardparis added a commit that referenced this issue Nov 15, 2024
@edouardparis
Merge #1451: descriptors: fix max satisfaction weight for Taproot mul…
cfe653f 
…tisig primary path spends

6e74a96 Revert "spend: add 10 sats to fee for 1 sat/vb txs" (Michael Mallan)
cf88aca descriptors: fix satisfaction size for Taproot (Michael Mallan)
e9c6995 qa: add threshold paramater for multisig descs (Michael Mallan)

Pull request description:

  This is a fix to #1371 and the related #1322.

  As per #1371 (comment), this adds the varint length for the script and control block elements of a Taproot primary path spend.

  I think this is what caused #1322 and so I have reverted the change from #1323.

ACKs for top commit:
  edouardparis:
    utACK 6e74a96

Tree-SHA512: 754e5c2186de853cde9006aeab7989141a4d363b9e3d8adb3f0264bcbca7e3b56a94822d434f6f7d8108e7c0e3023959fa407643e5868082f8981c5ce10b9a1e
@nondiremanuel nondiremanuel moved this from In Review to Todo in Liana General Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jp1ac4 jp1ac4

Labels
Bug Something isn't working as expected
Projects
Liana General
Status: Todo
Milestone
v10 Liana - UI fixes and other activi...
Development

No branches or pull requests
3 participants
@darosior @nondiremanuel @jp1ac4