spend: ensure fee above min relay value #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick change to prevent the fee being below the min relay fee.
|
utACK 74a53ba. Looking forward to a real fix. |
edouardparis
added a commit
that referenced
this pull request
Nov 15, 2024
…tisig primary path spends 6e74a96 Revert "spend: add 10 sats to fee for 1 sat/vb txs" (Michael Mallan) cf88aca descriptors: fix satisfaction size for Taproot (Michael Mallan) e9c6995 qa: add threshold paramater for multisig descs (Michael Mallan) Pull request description: This is a fix to #1371 and the related #1322. As per #1371 (comment), this adds the varint length for the script and control block elements of a Taproot primary path spend. I think this is what caused #1322 and so I have reverted the change from #1323. ACKs for top commit: edouardparis: utACK 6e74a96 Tree-SHA512: 754e5c2186de853cde9006aeab7989141a4d363b9e3d8adb3f0264bcbca7e3b56a94822d434f6f7d8108e7c0e3023959fa407643e5868082f8981c5ce10b9a1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick change to address #1322.
It adds 10 sats to the fee for a non-replacement transaction targeted at 1 sat/vb.