Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

422 new table 5 02 03 measurementobserving method ocean #445

Merged

Conversation

amilan17
Copy link
Member

@amilan17 amilan17 commented Jan 16, 2023

issue #422

anthoninlize and others added 4 commits January 13, 2023 09:58
Create 5-02-03.csv for initial Measurement/observing method (ocean)
Fixing breaking CSV and adding periods where missing.
Adding notations
@amilan17 amilan17 requested a review from joergklausen January 16, 2023 13:23
Copy link
Contributor

@joergklausen joergklausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal does not include duplicates and does not introduce inconsistencies as far as I can see. In keeping with the other code tables for methods, the notations will have to be numbers, not character strings. This table is pertinent for the ocean domain, even though it may be relatively short-lived as an individual table in view of consolidating the methods tables into one.

anthoninlize and others added 2 commits January 17, 2023 16:32
New notations (numbers)
@amilan17 amilan17 requested a review from joergklausen January 20, 2023 12:01
@amilan17 amilan17 linked an issue Jan 20, 2023 that may be closed by this pull request
Copy link
Contributor

@joergklausen joergklausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as is, and sorry for the delay ...

@amilan17 amilan17 merged commit 6085ef1 into FT2023-1 Feb 8, 2023
@amilan17 amilan17 deleted the 422-new-table-5-02-03-measurementobserving-method-ocean branch February 8, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New table 5-02-03: Measurement/observing method (ocean)
3 participants