Wire-up the revert from history ability

[marecar3]

Fixes part of wordpress-mobile/gutenberg-mobile#182

This change adds History option to the Gutenberg editor. The behavior is same as Aztec, when an older revision is selected among the old revision list the editor content is updated with that revision. After that we need to tap Update button if we want to publish the new content, we can still discard the content by tapping "Discard Local changes" or from Toolbar with Undo and Redo buttons.

It's tested against a corresponding gutenberg-mobile PR

Test :
Add wp.BUILD_GUTENBERG_FROM_SOURCE = true in gradle.properties

[hypest]

Add wp.BUILD_GUTENBERG_FROM_SOURCE = true in gradle.properties

👋 @marecar3 , I wonder, why is building from source needed? Have you encountered some problem with the binary build?

[hypest]

or from Toolbar with Undo and Redo buttons

I tried using the Undo button from the toolbar but the post still ends up being marked as changed.
Steps:

1. Open a GB post
2. Load a historical version
3. Wait for the "undo" snackbar to hide and tap on the "Undo" button of the toolbar. The post content returns to the previous one.
4. Tap back to exit the editor. Notice the post being marked with "Local changes"

I think I'd expect the post to not be marked as such. WDYT?

[mzorz]

I've tried the same as @hypest, apparently it tries to update the remote version (the Post uploader is triggered), when it should remain the same.

In my case I used this:

Steps to repro:

1. start a new gutenberg post
2. type a title
3. start a paragraph, enter "first version" as text.
4. tap back
5. observe the post gets uploaded as a draft
6. open it again and edit paragraph "first version" enter something else, for example I entered "second version"
7. tap back to make the first entry in history
8. open it again
9. now add a new paragraph with text "hello"
10. tap back, open it again and tap on History to see you have 2 entries there.
11. load one of the older entries
12. wait for the snackbar to hide
13. tap on undo
14. tap back - the post is uploaded (IIUC, it shouldn't).

NOTE: If you set airplane mode ON before step 14, the post is then marked with Local changes as described in the comment above.

[mzorz]

We confirmed with @marecar3 that these situations (#8768 (comment) and #8768 (comment)) are happening with Aztec alone as well, so they are not related to this specific PR.

[hypest]

I'd suggest tackling what happens with the Undo/Redo buttons in a separate PR so we can merge this one that implements the revert from history.

[mzorz]

I'd suggest tackling what happens with the Undo/Redo buttons in a separate PR so we can merge this one that implements the revert from history.

Agreed, that's being tackled by this other PR #8773. This one is LGTM from my side - will approve shortly.

[mzorz]

will approve shortly.

@marecar3 please let us know when you're able to make the changes suggested by @hypest and this PR is ready for another round 👍

[hypest]

LGTM!

[hypest]

👋 @marecar3 , it seems that this PR got merged without first updating the submodule hash to point to the gutenberg-mobile master after the dependent PR got merged. Can you open a new PR to point to master? Thanks!

[marecar3]

Hey @hypest sorry for missing that one.
Here is the PR #8780