Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Gutenberg UI into the app editors #182

Closed
19 tasks done
koke opened this issue Oct 22, 2018 · 7 comments
Closed
19 tasks done

Integrate Gutenberg UI into the app editors #182

koke opened this issue Oct 22, 2018 · 7 comments
Assignees
Milestone

Comments

@koke
Copy link
Member

koke commented Oct 22, 2018

Once we bring Gutenberg in the apps with #163, we'll need to connect the UI pieces so that the editor:

  • Shows a top bar with the same options as Aztec (preview, document options)
  • Can load a post from the app
  • Can save changes and upload a post

Task list:

iOS

  • Working setup of a Native Module for communication between RN and Native.
  • Send initial html content (Native -> RN)
    - Close button (RN -> Native [?]) (Handled in the Native side)
  • Retrieve current content (Native -> RN -> Native) (Maybe not needed for Alpha)
  • Save button implementation in WPiOS side.
  • Create new (empty) post. 1d
  • Implement content change detection, similar to Aztec
    More button options:
  • Implement Save as draft 1d
  • Implement Preview 1d
  • Implement Post settings 1d
  • Switch to html 1d
  • Add History option(if it is not a big deal) 1d

Android

  • Shows a top bar with the same options as Aztec (preview, document options) (3days including all project scaffolding)
  • Can load a post from the app (1day)
  • Can save changes and upload a post (3days)
  • Implement content change detection, similar to Aztec (1day)
  • Create new (empty) post (1d)
  • Handle device rotation (2days)
  • Fix reverting to a revision from History (if it is not a big deal) 1d
  • Cleanup the GutenbergEditorFragment class (remove unused lines, unused menus) (1day)
@koke
Copy link
Member Author

koke commented Oct 24, 2018

We talked in slack already, but leaving a comment here for reference, @etoledom is looking at breakdown and estimates for this one

@etoledom
Copy link
Contributor

etoledom commented Oct 24, 2018

After playing around with this tasks, I believe that this is more about overall communication between RN and Native, namely Native Modules.

  • Working setup of a Native Module for communication between RN and Native.

It would be good to identify all the communication points needed to satisfy the Alpha milestone. So far I can think of the following:

  • Send initial html content (Native -> RN)
  • Save button (RN -> Native [?])
  • Close button (RN -> Native [?])
  • Retrieve current content (Native -> RN -> Native) (Maybe not needed for Alpha)

The list could grow (or shrink). Some of them are super simple (few hours or less) and others might take longer (few days). Many of them are already working on the example branch (iOS) but none is yet merged.

I'd also like to find a way to start merging step by step at some point, but for that we should coordinate with Android. Check if this solution works for both platforms and agree on a RN side interface (method names) and a common place to document them.
(Talking with @hypest , we decided to go faster and let one platform accommodate to the one that first implemented the solution)

Edited:
With some simplifications, and moving some subtasks to Beta, I believe we could work this out in one sprint time.

@hypest
Copy link
Contributor

hypest commented Oct 31, 2018

Checklist with the Android side of the ticket:

- [x] Shows a top bar with the same options as Aztec (preview, document options)
- [x] Can load a post from the app
- [x] Can save changes and upload a post
- [ ] Cleanup the GutenbergEditorFragment class (remove unused lines, unused menus, handle device rotation)

Stroke through these ^ since they will live in the ticket description directly as per #182 (comment).

@koke
Copy link
Member Author

koke commented Nov 7, 2018

@hypest @etoledom I moved the checklists to the description, so the progress is visible on the issue:

screen shot 2018-11-07 at 10 27 45

Please make sure you update those as they get completed or change, and also can you add estimates per task so we can have an idea how much is done?

@hypest
Copy link
Contributor

hypest commented Nov 13, 2018

Noticed that we don't have "create new (empty) post" as a task in the list so, going to add it. cc @etoledom

@etoledom
Copy link
Contributor

Thank you!
Added estimation for create new (empty) post iOS side.

@hypest
Copy link
Contributor

hypest commented Dec 13, 2018

All subtasks completed, closing this. 🎉

@hypest hypest closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants