Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to toggle html/visual modes for Gutenberg editor #10558

Merged
merged 6 commits into from
Nov 28, 2018
Merged

Add ability to toggle html/visual modes for Gutenberg editor #10558

merged 6 commits into from
Nov 28, 2018

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Nov 27, 2018 •
edited
Loading

Fixes part of wordpress-mobile/gutenberg-mobile#182

Adds ability to toggle html/visual modes for Gutenberg editor:

simulator screen shot - iphone 7 - 2018-11-27 at 21 39 15

Dependens on this PR We need to merge that first and revert back the pod file changes and then merge this.

To test:

Prerequisites

  • Remove what's under pods folder and run "rake dependencies"
  • checkout feature/switch-to-html branch from gutenberg-mobile repo on a separate folder, run yarn install, yarn start on this path
  • open XCode and Option+Click Run button
  • Select "Run" option on the left
  • Select Arguments on right and then check "gutenberg" option
  • Run the app

Do all tests of the gutenberg-mobile PR on WPiOS also.

@pinarol pinarol requested a review from etoledom November 27, 2018 18:37
@pinarol pinarol changed the title Try/gutenberg toggle mode Add ability to toggle html/visual modes for Gutenberg editor Nov 27, 2018
@etoledom etoledom added this to the 11.4 milestone Nov 28, 2018
@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Nov 28, 2018
etoledom
etoledom approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough and it works great! ✅
Let's keep rolling :shipit:

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController+MoreActions.swift Outdated Show resolved Hide resolved
@pinarol pinarol merged commit 3efb976 into develop Nov 28, 2018
@pinarol pinarol deleted the try/gutenberg-toggle-mode branch November 28, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@pinarol pinarol

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @etoledom