Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad layout on bottom sheets with big text sizes #1906

Closed
etoledom opened this issue Feb 14, 2020 · 2 comments · Fixed by #1914
Closed

Bad layout on bottom sheets with big text sizes #1906

etoledom opened this issue Feb 14, 2020 · 2 comments · Fixed by #1914
Assignees
Labels
[Type] Bug Something isn't working [Type] Regression Existing functionality that got broken

Comments

@etoledom
Copy link
Contributor

Describe the bug
iOS: Using accessibility text sizes, the inserter looses the column layout.
Android: The Media selector options on Image Blocks gets its layout broken.

layout

To Reproduce
Steps to reproduce the behavior on iOS:

  1. Activate one of the big accessibility text sizes on the OS system.
  2. Open the block inserter.
  3. Check that the layout is not right.

Steps to reproduce the behavior on Android:

  1. Activate one of the big text sizes and a big display size on the OS system.
  2. Add an image block.
  3. Open the media selector as shown in the screenshot.
  4. Check that the layout is not right.

Expected behavior
The layout should be as expected.

Not sure if this PR might be related to these issues: #1837

cc @lukewalczak @pinarol

@etoledom etoledom added [Type] Bug Something isn't working [Type] Regression Existing functionality that got broken labels Feb 14, 2020
@rachelmcr
Copy link
Member

This also seems related to the i18n issue observed in the block picker in #1907.

@lukewalczak
Copy link
Contributor

Thanks! Working on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working [Type] Regression Existing functionality that got broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants