Correct layout within bottom-sheet [workaround] #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lukewalczak
force-pushed
the
bottom-sheet-workaround
branch
from
f2e53cb to
e7ff116
Compare
lukewalczak
force-pushed
the
bottom-sheet-workaround
branch
from
2558dba to
1d03263
Compare
etoledom
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Approved via WordPress/gutenberg#18574 (review)
Great job! 🎉
This was referenced Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1404
Ref to gutenberg PR: WordPress/gutenberg#18574
To test:
1.Run the app on a smaller device or on the regular in horizontal mode
2.User should be able to scroll through all the blocks / add them
3.Please check also other bottom-sheets in the app e.g: Image settings
PR submission checklist:
RELEASE-NOTES.txtif necessary.