Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu item width inside the inserter #1914

Merged
merged 6 commits into from
Feb 17, 2020
Merged

Fix menu item width inside the inserter #1914

merged 6 commits into from
Feb 17, 2020

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Feb 14, 2020 •
edited
Loading

Fixes #1906
Fixes #1907

Ref to gutenberg: WordPress/gutenberg#20238

To test:

  1. Change device font size to the largest
  2. Change display zoom to max (if available)
  3. Open the app
  4. Press the inserter
  5. Observe if all the items are displayed properly within a grid

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak mentioned this pull request Feb 14, 2020
Merged
6 tasks
@lukewalczak lukewalczak requested a review from etoledom February 14, 2020 15:53
@lukewalczak
Copy link
Contributor Author

@bisko @etoledom Could you please check the latest changes?

etoledom
etoledom approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20238 (review)

@lukewalczak lukewalczak merged commit 88d7b03 into develop Feb 17, 2020
@lukewalczak lukewalczak deleted the callstack/rnmobile/patch-bottom-sheet branch February 17, 2020 14:07
This was referenced Feb 17, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
2 participants
@lukewalczak @etoledom