-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text added with iOS dictation disappears #5165
Comments
Thanks for opening the issue @reginabally! This is definitely an annoying bug for users that use dictation, which by the way it's a very interesting feature for writing text in a post quickly 🙂. I noticed that the text remains if you tap on the microphone button after dictating, but any other action like tapping on a different block, typing text, or scrolling the content makes the text disappear. |
TIL! Thanks for pointing that out, @fluiddot! I will inform the user about this trick. |
I've been running into this a lot too. Do we need more information? I'm happy to provide what I can. |
We haven't investigated the issue yet but any extra information is always welcomed 🙂. I hope we can prioritize it soon and address it in the next WordPress-iOS versions 🤞 . |
Another report in p1672863996840939-slack-C03URUK5C. The video recording was too large to be uploaded here. Please check the Slack thread for the video if needed. Device: iPhone 14: |
I've been looking at this on/off between other project work and wanted to take the chance to share my findings so far:
To fix this, we need to either:
|
Thanks @SiobhyB for investigating the issue and sharing your findings 🙇 !
Ah, it's interesting that we bumped into a similar problem in the past and provided a workaround.
Definitely, we should try to address the issue in the long run. However, since this is affecting the editing experience, I'd advocate trying first the approach of using the |
I wanted to update on some investigations into this option:
This doesn't seem as straightforward as it may seem, as there doesn't appear to be a straightforward way to detect when dictation is active since iOS 16 (previously, it was possible to use textInputMode for this purpose, but not any more). I found this StackOverflow post which seems to have a good lead involving method swizzling: https://stackoverflow.com/questions/74024881/detect-text-is-entered-using-dictation-on-ios-16/74024882 However, I'm beginning to wonder whether this would end up being more or less complex than the second option:
I have some upcoming AFK, so won't have time to look further into this in the next week or so, but would be happy to keep looking after that if no one beats me to it. :) |
I totally agree, if the first hack-ish option becomes more complex than the second I'd advocate directly going with the second one to address the issue 👍. |
👋 Hey @SiobhyB - I looked at this briefly and wondered what would happen if we didn't provide the This may only work on iOS 16, but it seems to be an improvement. I'm not quite sure what happened at the 00:38 mark to uncapitalize the first letter... Video contains audio Screen.Recording.2023-03-14.at.11.39.09.mov |
@twstokes, you could well be right here, I did a quick test and saw the same improvements as you. I wonder if the changes to dictation in iOS 16 negated any need for these previous hacks. I'll do some more thorough testing tomorrow. ...and also go hide in a corner for potentially making this way more complicated than needs be. 🤦♀️ I really appreciate you taking the time to take a look, thank you. |
I wonder the same!
In your defense Aztec bugs typically do mean complicated 😆, plus the jury's still out on whether what I proposed will work. I regret saying "looked at this briefly" because it sounds like it downplays previous efforts. It helped that I had a long battle or two with Aztec previously. 😄
Thanks for digging into this! 🙇 |
To follow up, I couldn't find any issues with removing the I've updated the PR at WordPress/gutenberg#49056 and will set it as ready for review shortly, after a bit more testing. Thanks so much @twstokes for your help here 🙇♀️ |
Just wanted to note, too, that I've been able to replicate this sporadically. I'll create a separate issue for this as, though not ideal, it still seems a lot better than the current state of dictation for iOS. |
Re-opened as we needed to revert the proposed fix in WordPress/gutenberg#49154. |
Making a note of a 1 star review that I've offered to follow up with when a fix has been merged:
|
Going ahead to close as this was fixed in WordPress/gutenberg#49452. There are still some edge cases where the cursors placement appears off, which will be addressed separately in WordPress/gutenberg#51227. The main fix will be included in the 22.6 version of the app, set to be available on June 26th. If we have a beta release for Gutenberg Mobile, we could also include this as part of that. I also followed up with the review noted above. |
Describe the bug
Reported in 5566465-zd-woothemes.
When using the iOS dictation to add text to the app's editor, the text will disappear when tapping another block.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect the text stays in the editor even if I moved to another block in the editor.
Screen recording
RPReplay_Final1663723390.MP4
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: