Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTING ONLY: DO NOT MERGE: Fix dictation issue on iOS #20433

Closed
wants to merge 4 commits into from
Closed

TESTING ONLY: DO NOT MERGE: Fix dictation issue on iOS #20433

wants to merge 4 commits into from

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Mar 29, 2023 •
edited
Loading

Proposed fix for wordpress-mobile/gutenberg-mobile#5165.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 29, 2023 •
edited
Loading

Fails
🚫 Podfile: reference to a commit hash for Gutenberg,RNTAztecView
Warnings
⚠️ Localizable.strings should only be updated on release branches because it is generated automatically.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@SiobhyB SiobhyB self-assigned this Mar 29, 2023
@SiobhyB SiobhyB mentioned this pull request Mar 29, 2023
Merged
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 29, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20433-c4aa26e
Version22.0
Bundle IDorg.wordpress.alpha
Commitc4aa26e
App Center BuildWPiOS - One-Offs #5372
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 29, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20433-c4aa26e
Version22.0
Bundle IDcom.jetpack.alpha
Commitc4aa26e
App Center Buildjetpack-installable-builds #4400
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@SiobhyB SiobhyB mentioned this pull request Mar 30, 2023
Merged
2 tasks
@SiobhyB SiobhyB closed this May 12, 2023
@SiobhyB SiobhyB deleted the gutenberg/fix-dictation-regression branch May 12, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SiobhyB SiobhyB

Labels
[Status] DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiobhyB @wpmobilebot