Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dictation regression on iOS #5612

Merged
merged 31 commits into from
Jun 5, 2023
Merged

Fix dictation regression on iOS #5612

merged 31 commits into from
Jun 5, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Mar 30, 2023

Proposed fix for #5165.

Related PRs:

Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.


PR submission checklist:
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 30, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB self-assigned this May 12, 2023
twstokes

This comment was marked as duplicate.

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved in WordPress/gutenberg#49452. 🚀

@SiobhyB SiobhyB enabled auto-merge June 5, 2023 09:16
@SiobhyB SiobhyB merged commit de393f3 into trunk Jun 5, 2023
@SiobhyB SiobhyB deleted the fix/dictation-regression-ios branch June 5, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants