-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Justify" to text-alignment options on blocks that support text-alignment - Jetpack/WordPress.com only #575
Comments
@iamthomasbishop we don't support justify on the web is this something we want to do for mobile-only? |
It's supported on WordPress.com (and it's broken, from the looks of it 😬), but since it's not supported in Core Gutenberg, we can probably close this one for now. |
Note: we had a review on the Play Store from someone who wants "Justify" back (both on the Web and Mobile). |
Noting another Play Store review requesting the option to justify text.
Translated with http://translate.google.com/
1-star app review by Danny feeer – May 26, 2020 - WPiOS 14.8.2 - Brazil |
@SergioEstevao @iamthomasbishop - I think we should reopen that one, even if we make it a Jetpack-only feature (since it's not supported in core). |
@maxme Is the underline capability enabled via Jetpack or is it a third-party plugin on WordPress.com that makes it available? |
So at the moment in GB-mobile we have the following
- Both platforms are able to render the underlines
- On iOS there is a system tooltip in RichText that allows you to set the
underline
So we are not using any of Jetpack code to support underline, we probably
need to investigate how we can enhance blocks that exist in Core to add new
functionality to them.
…On Mon, 1 Jun 2020 at 22:41, Thomas Bishop ***@***.***> wrote:
@maxme <https://github.com/maxme> Is the underline capability enabled via
Jetpack or is it a third-party plugin on WordPress.com that makes it
available?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#575 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7CUI4A6LH2WKGHW2ST6TRUQOBBANCNFSM4GVKF7TA>
.
|
@SergioEstevao I meant to say justify, not underline — my bad. My question is where is justify enabled? Sorry for the confusion. |
So for justify we support render of it on both apps, but we just don't show
the option to switch to it.
I think that on the web that is added by WP.com has an extra format button,
is not even added has another option on the alignment dropdown.
…On Tue, 2 Jun 2020 at 14:03, Thomas Bishop ***@***.***> wrote:
@SergioEstevao <https://github.com/SergioEstevao> I meant to say *justify*,
not underline — my bad. My question is where is *justify* enabled? Sorry
for the confusion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#575 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7CUNREFNBHQIPDSBK7TDRUT2DZANCNFSM4GVKF7TA>
.
|
I see the option there https://wordpress.org/gutenberg/ and I see it on simple and Atomic sites (I disabled all plugins but Jetpack), but I don't see it on a non-atomtic Jetpack site. I guess it's a layer added from wpcom. |
If it's on the GB demo wouldn't it be coming from core GB? I don't remember seeing justify on core when we first investigated, so maybe that's been added relatively recently. If this is the case, we can probably safely add it justify to the toolbar, although we might want to tuck it behind a similar dropdown/menu. We were recently talking about how we might consolidate inline text style options, so maybe now is the time to do this. Also worth noting that justify doesn't work properly on the demo (nor on wpcom — tried both Chrome and Safari on Mac) 😬 |
Justified text was removed from WordPress in version 4.7 for accessibility reasons. Announcement: https://make.wordpress.org/core/2016/10/28/editor-changes-in-4-7/. Related article: http://mediaaccess.org.au/accessibledocumentservice/2015/08/text-justification-is-a-key-accessibility-issue-in-documents/. Text justification was added to WordPress.com Gutenframe on Mar 29 2019 (D26137) and to Jetpack/Atomic on Apr 25 2019 (Automattic/jetpack#12070) due to popular demand (wp-calypso/28696). Still, there are many requests for the option to justify text in core Gutenberg but the decision to remove the option still stands as of today. I am in favor of supporting the option at least for WordPress.com and Jetpack because it is supported on the web for those types of sites and because it is a popular request—it's odd to me that this feedback isn't being communicated well because I know for sure that it does come up! Here is another recent example from an app review:
|
Ok, let's work on that (added a project to our timeline), we should think of an extensible design that allows us to add more options. Thanks @designsimply for the history on that feature. And I agree that we should at least add it for Jetpack and WordPress.com sites. |
I found another app review asking for text justification.
Auto-translated from Spanish:
2-star app review by Anye M - 6/28 3:35 - LG G6 Android 9 |
|
I found another App Review which asks for text justification:
|
Another app review from the past mentioned not being able to justify text (I sent them an update letting them know the other alignment options should be available).
|
Platform: Google Play Store |
The title basically says it all. Worth noting that this would initially be beneficial on
Paragraph
andHeading
Blocks as we start adding text-alignment options.Icon options, depending on if we end up using Dashicons or Material:
Related proposal on Core (not final at the time of this posting): Automattic/wp-calypso#28696
The text was updated successfully, but these errors were encountered: