Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.32.0 #2467

Merged
merged 104 commits into from
Jul 10, 2020
Merged

Release 1.32.0 #2467

merged 104 commits into from
Jul 10, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jul 8, 2020 •
edited
Loading

Release for Gutenberg Mobile 1.32.0

Related PRs

Extra PRs that Landed After the Release Was Cut

NA

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Check WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Release number was bumped
  • Aztec dependencies are pointing to a stable release
    • iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
    • Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
  • Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
  • Bundle package of the release is updated
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release

SergioEstevao and others added 30 commits June 17, 2020 17:03
@SergioEstevao
Create script to automate release process steps.
3802957
@SergioEstevao
Add json edit npm package to develop dependencies.
87bee15
@SergioEstevao
Update script to update PR template with version number.
80f7cb7
@mchowning
Make release script create a PR that is a draft
1ff83e8
@mchowning
Add some space between commands
15de1e3
@mchowning
Make release script not depend on where it is run from
b178b8c
@mchowning
Make release script failures quick and informative
c6c506a
@mchowning
Run 'yarn install' in release script
05605f9
@mchowning
Insure Github CLI is installed
d344795
@mchowning
Branch checks
0f7f3c3
@mchowning
Update react-aztec path in release checklist
3f6f56e
@enejb
Add Release notes doc
51ae323
@SergioEstevao
Merge branch 'develop' into issue/automate_release_prs_creation
04f1b51 
# Conflicts:
#	yarn.lock
@SergioEstevao
Replace uses of yarn with npm.
1d03555
@SergioEstevao
Replace reference to master to main.
eb89fe5
@SergioEstevao
Update pod install step to use npm step.
4064955
@SergioEstevao
Update package-lock file.
4c3ec15
@SergioEstevao
Update GB reference.
5d2d2e3
@SergioEstevao
Update bundles.
5c57946
@mchowning
Update gutenberg submodule ref
c4a32fd
@mchowning
Update gutenberg submodule ref
fc4a27b
@enejb
Fix typo
364a4d8
@enejb
fix typo
9371718
@enejb
Minor text fixes
0318369
@SergioEstevao
Merge pull request #2433 from wordpress-mobile/release/merge_main_1.3…
2d8fb62 
…1.0_to_develop

Release/merge main 1.31.0 to develop
@SergioEstevao
Update GB reference.
58d5bb0
@SergioEstevao
Merge branch 'develop' into issue/331_mention_support_trigger_on_keyp…
6db0188 
…ress

# Conflicts:
#	bundle/android/App.js
#	bundle/android/App.js.map
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
@ceyhun
Only run iOS device checks
b6ee0c0
@ceyhun
Bundle iOS 25 times
8b33009
@ceyhun
Bundle iOS 25 times with watchman
4dc968c
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SergioEstevao SergioEstevao requested a review from mchowning July 8, 2020 12:53
@SergioEstevao SergioEstevao added this to the 1.32 milestone Jul 8, 2020
@SergioEstevao SergioEstevao marked this pull request as ready for review July 8, 2020 12:53
mchowning
mchowning approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything looks good! :shipit:

@SergioEstevao SergioEstevao merged commit d6c6172 into main Jul 10, 2020
@SergioEstevao SergioEstevao deleted the release/1.32.0 branch July 10, 2020 21:01
@hypest
Copy link
Contributor

hypest commented Jul 14, 2020

👋 looks like we didn't update the package-lock.json and the version mentioned there is still the previous (1.31.1) one. It's not easy to manually merge package-lock.json conflicts so, may I suggest adding a step to the release process to ensure that the lock file has the proper version?

Without updating the lock file, npm install ends up introducing changes to it.

@mchowning
Copy link
Contributor

looks like we didn't update the package-lock.json and the version mentioned there is still the previous (1.31.1) one. It's not easy to manually merge package-lock.json conflicts so, may I suggest adding a step to the release process to ensure that the lock file has the proper version?

This is addressed in #2490.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol left review comments

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.