Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iscsi ifaces instead of offload card (bsc#1231385) - SLE-15-SP7 #137

Merged
merged 17 commits into from
Nov 12, 2024

Conversation

teclator
Copy link
Contributor

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11794958715

Details

  • 127 of 183 (69.4%) changed or added relevant lines in 5 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.6%) to 28.866%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/clients/inst_iscsi-client.rb 0 2 0.0%
src/include/iscsi-client/helps.rb 0 4 0.0%
src/include/iscsi-client/dialogs.rb 0 6 0.0%
src/include/iscsi-client/widgets.rb 0 15 0.0%
src/modules/IscsiClientLib.rb 127 156 81.41%
Files with Coverage Reduction New Missed Lines %
src/include/iscsi-client/widgets.rb 1 0.0%
src/include/iscsi-client/dialogs.rb 1 0.0%
src/clients/inst_iscsi-client.rb 1 0.0%
src/modules/IscsiClientLib.rb 21 66.96%
Totals Coverage Status
Change from base Build 11124567340: -1.6%
Covered Lines: 728
Relevant Lines: 2522

💛 - Coveralls

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit 40ed6cd into SLE-15-SP7 Nov 12, 2024
10 checks passed
@teclator teclator deleted the merge_SLE-15-SP6 branch November 12, 2024 15:47
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #353404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants