Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iscsi ifaces instead of offload card (bsc#1231385) - master #138

Merged
merged 19 commits into from
Nov 12, 2024

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Nov 12, 2024

It merges #137 into master

Once we merge this request we should also adapt agama

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11801322205

Details

  • 127 of 182 (69.78%) changed or added relevant lines in 5 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.6%) to 28.861%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/clients/inst_iscsi-client.rb 0 2 0.0%
src/include/iscsi-client/helps.rb 0 4 0.0%
src/include/iscsi-client/dialogs.rb 0 6 0.0%
src/include/iscsi-client/widgets.rb 0 15 0.0%
src/modules/IscsiClientLib.rb 127 155 81.94%
Files with Coverage Reduction New Missed Lines %
src/include/iscsi-client/dialogs.rb 1 0.0%
src/include/iscsi-client/widgets.rb 1 0.0%
src/clients/inst_iscsi-client.rb 1 0.0%
src/modules/IscsiClientLib.rb 21 67.15%
Totals Coverage Status
Change from base Build 11127353164: -1.6%
Covered Lines: 727
Relevant Lines: 2519

💛 - Coveralls

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit 59f0cb0 into master Nov 12, 2024
10 checks passed
@teclator teclator deleted the merge_SLE-15-SP7 branch November 12, 2024 18:23
Copy link

✅ Autosubmission job #11803384462 successfully finished
✅ Created submit request #1223768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants