Wallets and treasury update #182

BobTheBuidler · 2021-12-15T16:49:37Z

No description provided.

yearn/outputs/describers/registry.py

yearn/constants.py

yearn/outputs/postgres/utils.py

banteg · 2021-12-15T19:57:28Z

yearn/treasury/treasury.py


    def unit_debt(self, block=None) -> dict:
+        # NOTE: This only works for YFI based debt, must extend before using for other collaterals


maybe this should be an assertion so a developer knows some part is not implemented when this occurs

hmm, I'm not sure what we could assert there, since you don't pass a particular collateral type as an arg. Maybe better to change the method name for clarity?

yearn/treasury/treasury.py

yearn/yearn.py

yearn/entities.py

yearn/outputs/victoria.py

yearn/outputs/describers/vault.py

services/dashboard/docker-compose.yml

scripts/transactions_exporter.py

yearn/outputs/postgres/utils.py

BobTheBuidler · 2021-12-16T21:12:20Z

one last thing to fix: stablecoin buckets for MIM, UST, RSV

BobTheBuidler · 2021-12-17T15:25:22Z

@mariuspod after the most recent changes, I've nuked my VM db on my staging server and am repulling from scratch to confirm nothing broke in our 185 commit rebase
Data can be found at staging.yfistats.com

mariuspod · 2022-01-18T08:57:14Z

blocked by #186

…so it doesn't raise IntegrityException.

…d less ORM surprises.

yearn/entities.py

banteg · 2022-01-31T13:48:35Z

yearn/outputs/describers/vault.py

+
+def _get_price(token_address, block=None):


i don't like this function, it looks super messy.

banteg · 2022-01-31T13:51:53Z

yearn/prices/band.py

@@ -13,14 +13,38 @@
    Network.Fantom: '0x56E2898E0ceFF0D1222827759B56B28Ad812f92F'
 }

+supported_assets = {
+    # https://docs.fantom.foundation/tutorials/band-protocol-standard-dataset#supported-tokens


good addition. if they add a registry in the future, it would be preferred to hardcoding addresses.

banteg · 2022-01-31T13:53:44Z

yearn/treasury/treasury.py

-from yearn.prices.magic import get_price, logger as logger_price_magic
-from yearn.exceptions import PriceError
+from yearn.prices.magic import get_price
+from yearn.prices.magic import logger as logger_price_magic


why not import magic and ref logger as magic.logger? seems clearer.

banteg · 2022-01-31T13:55:22Z

yearn/treasury/treasury.py

 from yearn.utils import contract

-from yearn.constants import TREASURY_WALLETS, ERC20_TRANSFER_EVENT_HASH, ERC677_TRANSFER_EVENT_HASH
-
 logger = logging.getLogger(__name__)
 logger_price_magic.setLevel(logging.CRITICAL)


i don't think it's appropriate to change log level of another module from outside a script or a debug session

banteg · 2022-01-31T19:55:35Z

yearn/prices/pps.py

+
+    @ttl_cache(maxsize=None, ttl=600)
+    def get_price(self, asset, block=None):
+        base_block = next(iter(assets[chain.id][asset]))


this can throw KeyError and StopIteration on empty list

banteg · 2022-01-31T20:26:09Z

yearn/prices/pps.py

+networks = [ Network.Mainnet, Network.Fantom, Network.Arbitrum ]
+assets = {
+    Network.Mainnet: {
+      "0x03403154afc09Ce8e44C3B185C82C6aD5f86b9ab": 12429262,


delete the whole module, we shouldn't manually fix accounting errors, exporter should surface data as is

here is a period of nulls for this address:

12430455 first none

12430661 last none

This reverts commit d215e97.

…ass." This reverts commit 3efcdba.

BobTheBuidler force-pushed the wallets-and-treasury-testing-rebase branch 2 times, most recently from 6ce0392 to dd9cfc2 Compare December 15, 2021 17:46

BobTheBuidler marked this pull request as ready for review December 15, 2021 17:48

mariuspod self-requested a review December 15, 2021 19:28

banteg requested changes Dec 15, 2021

View reviewed changes

mariuspod suggested changes Dec 16, 2021

View reviewed changes

mariuspod added the do not merge This issue or pull request is in a holding pattern label Dec 16, 2021

BobTheBuidler changed the base branch from feat/fantom to master December 16, 2021 22:59

mariuspod force-pushed the wallets-and-treasury-testing-rebase branch from 4a09b17 to 905c566 Compare December 17, 2021 15:04

mariuspod approved these changes Dec 17, 2021

View reviewed changes

BobTheBuidler force-pushed the wallets-and-treasury-testing-rebase branch from e47d8ae to 26e7ed8 Compare December 24, 2021 22:36

BobTheBuidler force-pushed the wallets-and-treasury-testing-rebase branch from e408b0f to 28e9102 Compare January 17, 2022 23:14

BobTheBuidler force-pushed the wallets-and-treasury-testing-rebase branch 2 times, most recently from 1c6d8cb to 14a39f0 Compare January 19, 2022 16:19

BobTheBuidler added 13 commits January 27, 2022 14:29

feat: add skeleton

d3fc6b7

fix: temporarily disable victoria

ffd6d3a

feat: add total users

9ac47a2

feat: count wallets by # vaults used

67d5e11

feat: add total users by vault

2292dc9

fix: use Decimal instead of float

f4cb58c

feat: use pickle instead of csv for tx cache

57e9854

chore: refactor

0e9c248

chore: checkpoint tx pickle thru block 10949751

b9f84d1

feat: parallelism

c747e51

fix: accept new transfer event field labels

8888c5b

fix: handle reverts in price magic

7fcd660

fix: etherscan rate limit handler

96985c1

fix: move import to the right file

ba925c7

mariuspod force-pushed the wallets-and-treasury-testing-rebase branch 3 times, most recently from adf3c9c to ba925c7 Compare January 27, 2022 15:53

mariuspod added the testing label Jan 27, 2022

mariuspod and others added 9 commits January 28, 2022 22:27

feat: remove unused packages from docker image.

aac3ac5

chore: add FTMSCAN_TOKEN env var for ftm containers

10e7546

fix: remove IS_CONTAINER env var

b7582a5

fix: transactions-exporter TransactionIntegrityError on fresh startup

098dfee

chore: replace soon-to-be-deprecated df.append with pd.concat

175e16a

fix: don't fail when transaction_exporter has not exported anything yet.

76c6d57

fix: handle the entity creation more gracefully with the transaction …

0f25539

…so it doesn't raise IntegrityException.

feat: refactor db entities a bit for more standardized PKs and FKs an…

ad12946

…d less ORM surprises.

fix: adding band supported tokens.

9eca867

mariuspod added good to merge and removed do not merge This issue or pull request is in a holding pattern testing labels Jan 31, 2022

banteg approved these changes Jan 31, 2022

View reviewed changes

mariuspod added 3 commits January 31, 2022 18:45

fix: use PG* envs for postgres connection config.

b7daccb

wip: trying to move pricePerShare logic into its own price class.

3efcdba

fix: adding file to calculate price per share of a token

d215e97

banteg approved these changes Jan 31, 2022

View reviewed changes

mariuspod and others added 4 commits January 31, 2022 21:38

Revert "fix: adding file to calculate price per share of a token"

681f460

This reverts commit d215e97.

Revert "wip: trying to move pricePerShare logic into its own price cl…

2ecbb86

…ass." This reverts commit 3efcdba.

fix: propagate error when unable to read share price

4ebbac5

fix: handle crvaave incident

3214a0a

banteg merged commit 21ee091 into yearn:master Jan 31, 2022

BobTheBuidler deleted the wallets-and-treasury-testing-rebase branch January 31, 2022 22:03

BobTheBuidler mentioned this pull request Feb 1, 2022

Treasury and wallets #183

Closed

numan mentioned this pull request Feb 18, 2022

feat: Add github action to build and bush docker container image" numan/yearn-exporter#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wallets and treasury update #182

Wallets and treasury update #182

BobTheBuidler commented Dec 15, 2021

banteg Dec 15, 2021

BobTheBuidler Dec 15, 2021

BobTheBuidler commented Dec 16, 2021

BobTheBuidler commented Dec 17, 2021

mariuspod commented Jan 18, 2022

banteg Jan 31, 2022

banteg Jan 31, 2022

banteg Jan 31, 2022

banteg Jan 31, 2022

banteg Jan 31, 2022

banteg Jan 31, 2022


		def unit_debt(self, block=None) -> dict:
		# NOTE: This only works for YFI based debt, must extend before using for other collaterals

Wallets and treasury update #182

Wallets and treasury update #182

Conversation

BobTheBuidler commented Dec 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BobTheBuidler commented Dec 16, 2021

BobTheBuidler commented Dec 17, 2021

mariuspod commented Jan 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment