fix: Requesting ERC-20 or ERC-677 Transfer events in log filter. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking at the specific example with LINK and it appears we just have the wrong ABI cached. >>> Contract('0x514910771AF9Ca656af840dff83E8264EcF986CA')
<ERC20 Contract '0x514910771AF9Ca656af840dff83E8264EcF986CA'> # wrong
>>> Contract('0x514910771AF9Ca656af840dff83E8264EcF986CA')
<LinkToken Contract '0x514910771AF9Ca656af840dff83E8264EcF986CA'> # right |
banteg
requested changes
Dec 20, 2021
…test solc compiler patch version for contract compilations and remove handling of '(unknown)' events.
…he addresses for the log filter.
… in which fix event decoding for the given chainlink contract.
|
@banteg |
banteg
approved these changes
Jan 19, 2022
mariuspod
added a commit
to BobTheBuidler/yearn-exporter
that referenced
this pull request
Jan 27, 2022
…rn#186) * fix: Requesting ERC-20 or ERC-677 Transfer events in log filter. * fix: use brownie version that contains the ability to download the latest solc compiler patch version for contract compilations and remove handling of '(unknown)' events. * fix: don't import relative parts and use encode_* methods to encode the addresses for the log filter. * fix: typo in yaml file * feat: use brownie master branch which has the required changes merged in which fix event decoding for the given chainlink contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues in the treasury_exporter for ERC-677 transfer events which have a different signature than usual Transfer events:
function transferAndCall(address receiver, uint amount, bytes data) returns (bool success)ethereum/EIPs#677
Prior to this fix, these events fail the exporter because the topic filter for the usual ERC-20 transfer event doesn't match with the first topic of the received event.