-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ruby 2.3 install on centos 7 #1630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
=======================================
Coverage 63.27% 63.27%
=======================================
Files 30 30
Lines 1484 1484
=======================================
Hits 939 939
Misses 545 545 Continue to review full report at Codecov.
|
Don't approve this yet, apparently even if 2.3 the apps are installed on 2.3 and there are no paths to the original "ruby" |
As previously mentioned in #1472 the dependency on Ruby 2.3 is not intentional, and the target version is currently 2.0. The specific dependencies should be correctly locked in master to enable this. Are you currently working on 0.24.0 or on a recent git master? |
My issue is that i keep having to install older dependencies (at least on centos 7 ruby ) every time i install oxidized. Issues are with net-telnet and puma gem dependencies shows as follows
As you can see, there are no limiters on versions for puma and net-telnet, of which latest requires at 2.2 and 2.3 |
@Atroskelis thanks for the detail; could you specify if you install oxidized using This is a known issue in the current release (and will normally be resolved once a new release takes place), and is expected. It is not expected in current master. |
This should be resolved with the release of 0.25.1, could you see if the current gem / git is still having difficulties building under older Ruby versions? |
Sorry for the late reply. I tried installing oxidized on centos 7 a few days ago. The oxidized worked fine, as always, but oxidized-web has another dependency who needs Ruby 2.2 This time its rb-inotify.
|
net-telnet and puma both require Ruby to be over 2.2. Either you install the old variants of those 2, or update ruby to 2.3
As of #1718, minimal supported Ruby is 2.3 for both Thanks! |
net-telnet and puma both require Ruby to be over 2.2.
Either you install the old variants of those 2, or update ruby to 2.3
Pre-Request Checklist
rubocop --auto-correct
)rake test
)Description