Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ruby 2.3 install on centos 7 #1630

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Added ruby 2.3 install on centos 7 #1630

merged 2 commits into from
Mar 3, 2019

Conversation

Atroskelis
Copy link
Contributor

net-telnet and puma both require Ruby to be over 2.2.

Either you install the old variants of those 2, or update ruby to 2.3

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #1630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   63.27%   63.27%           
=======================================
  Files          30       30           
  Lines        1484     1484           
=======================================
  Hits          939      939           
  Misses        545      545

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a34dd...f6e1f48. Read the comment docs.

@Atroskelis
Copy link
Contributor Author

Don't approve this yet, apparently even if 2.3 the apps are installed on 2.3 and there are no paths to the original "ruby"

@wk
Copy link
Contributor

wk commented Nov 18, 2018

As previously mentioned in #1472 the dependency on Ruby 2.3 is not intentional, and the target version is currently 2.0.

The specific dependencies should be correctly locked in master to enable this. Are you currently working on 0.24.0 or on a recent git master?

@Atroskelis
Copy link
Contributor Author

My issue is that i keep having to install older dependencies (at least on centos 7 ruby ) every time i install oxidized.

Issues are with net-telnet and puma

gem dependencies shows as follows

Gem oxidized-0.24.0
  asetus (~> 0.1)
  bundler (~> 1.10, development)
  git (~> 1, development)
  minitest (~> 5.8, development)
  mocha (~> 1.1, development)
  net-ssh (~> 4.1.0)
  net-telnet (~> 0)
  pry (~> 0, development)
  rake (~> 10.0, development)
  rubocop (~> 0.57.1, development)
  rugged (>= 0.21.4, ~> 0.21)
  simplecov (>= 0, development)
  slop (~> 3.5)
Gem oxidized-web-0.11.1
  charlock_holmes (~> 0.7.5)
  emk-sinatra-url-for (~> 0.2)
  haml (~> 5.0)
  htmlentities (~> 4.3)
  json (>= 1.7.0)
  oxidized (~> 0.22)
  puma (~> 3)
  rack-test (~> 0.7.0)
  rails_best_practices (~> 1.19, development)
  rake (~> 10.0, development)
  rubocop (~> 0.57.1, development)
  sass (~> 3.3)
  sinatra (>= 1.4.6, ~> 1.4)
  sinatra-contrib (>= 1.4.6, ~> 1.4)

As you can see, there are no limiters on versions for puma and net-telnet, of which latest requires at 2.2 and 2.3

@wk
Copy link
Contributor

wk commented Nov 28, 2018

@Atroskelis thanks for the detail; could you specify if you install oxidized using gem from rubyforge, or if you experience this when building the oxidized and oxidized-web gems locally from the current git master?

This is a known issue in the current release (and will normally be resolved once a new release takes place), and is expected. It is not expected in current master.

@wk
Copy link
Contributor

wk commented Jan 23, 2019

This should be resolved with the release of 0.25.1, could you see if the current gem / git is still having difficulties building under older Ruby versions?

@Atroskelis
Copy link
Contributor Author

Sorry for the late reply.

I tried installing oxidized on centos 7 a few days ago. The oxidized worked fine, as always, but oxidized-web has another dependency who needs Ruby 2.2

This time its rb-inotify.

[root@itvmj30 librenms]# gem install oxidized-web
Fetching: charlock_holmes-0.7.6.gem (100%)
Building native extensions.  This could take a while...
Successfully installed charlock_holmes-0.7.6
Fetching: rack-1.6.11.gem (100%)
Successfully installed rack-1.6.11
Fetching: tilt-2.0.9.gem (100%)
Successfully installed tilt-2.0.9
Fetching: rack-protection-1.5.5.gem (100%)
Successfully installed rack-protection-1.5.5
Fetching: sinatra-1.4.8.gem (100%)
Successfully installed sinatra-1.4.8
Fetching: emk-sinatra-url-for-0.2.1.gem (100%)
Successfully installed emk-sinatra-url-for-0.2.1
Fetching: temple-0.8.0.gem (100%)
Successfully installed temple-0.8.0
Fetching: haml-5.0.4.gem (100%)
Successfully installed haml-5.0.4
Fetching: htmlentities-4.3.4.gem (100%)
Successfully installed htmlentities-4.3.4
Fetching: puma-3.11.4.gem (100%)
Building native extensions.  This could take a while...
Successfully installed puma-3.11.4
Fetching: rb-fsevent-0.10.3.gem (100%)
Successfully installed rb-fsevent-0.10.3
Fetching: ffi-1.10.0.gem (100%)
Building native extensions.  This could take a while...
Successfully installed ffi-1.10.0
Fetching: rb-inotify-0.10.0.gem (100%)
ERROR:  Error installing oxidized-web:
        rb-inotify requires Ruby version >= 2.2.

Atroskelis and others added 2 commits March 3, 2019 17:39
net-telnet and puma both require Ruby to be over 2.2.

Either you install the old variants of those 2, or update ruby to 2.3
@wk
Copy link
Contributor

wk commented Mar 3, 2019

As of #1718, minimal supported Ruby is 2.3 for both oxidized and oxidized-web. I've updated your proposed documentation changes to reflect that, and will shortly pull them in.

Thanks!

@wk wk merged commit 89bff41 into ytti:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants