Bump Minimal Ruby to 2.3 #1718
Merged
Bump Minimal Ruby to 2.3 #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
=======================================
Coverage 63.32% 63.32%
=======================================
Files 30 30
Lines 1475 1475
=======================================
Hits 934 934
Misses 541 541Continue to review full report at Codecov.
|
This was referenced Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Bump minimal supported Ruby to 2.3 from 2.0.0 officially, as well as net-ssh to 5 and rubocop to 0.65.
Reliance on a long end-of-life Ruby has resulted in an increasing number of issues cropping up, and the current oxidized-web (as well as oxidized) include a wide range of version locks of dependencies in an attempt to satisfy it. As of current v0.12.1, oxidized-web does not build on Ruby 2.0.0.
Some of the issues that cropped up include ytti/oxidized-web#179 and #1580, among others. Most distributions now ship with OpenSSL 1.1, which has an incompatibility with net-ssh 4.2, - but the newer net-ssh 5 requires ruby 2.2.6. This also affects the docker container distributed by the project.
This change set includes the minimal bump necessary to overcome these challenges. The recommended version of Ruby for Oxidized is Ruby 2.5.
This is expected to only inconvenience CenOS / RHEL 7 users (6 ships with a too old Ruby that already required RVM), which currently would encounter problems attempting to install oxidized-web in either case.