Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Bug - Deploying Stepper numbering #893

Closed
Madeline-UX opened this issue Oct 12, 2022 · 1 comment · Fixed by #907
Closed

UI Bug - Deploying Stepper numbering #893

Madeline-UX opened this issue Oct 12, 2022 · 1 comment · Fixed by #907
Assignees
@mike-winberry
Labels
possible-bug 🐛
Milestone
v0.26.1 (Zarf UI)

Comments

@Madeline-UX
Copy link
Contributor

Current

On the deployment page in the wizard - the stepper starts with 0

Screen Shot 2022-10-12 at 11 55 12 AM

Update

Change stepper numbering to start with 1

Screen Shot 2022-10-12 at 11 56 55 AM
@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Oct 12, 2022
@Madeline-UX Madeline-UX moved this from New Requests to Backlog in Zarf Project Board Oct 12, 2022
@Madeline-UX Madeline-UX added this to the Zarf UI - MVP milestone Oct 12, 2022
@jeff-mccoy jeff-mccoy added the UI label Oct 13, 2022
@mike-winberry mike-winberry moved this from Backlog to Doing Now in Zarf Project Board Oct 13, 2022
@mike-winberry
Copy link
Contributor

Screen.Recording.2022-10-13.at.12.21.17.PM.mov

@mike-winberry mike-winberry mentioned this issue Oct 13, 2022
Merged
1 task
@mike-winberry mike-winberry linked a pull request Oct 13, 2022 that will close this issue
Fixes #893 Deploying steps indexing. #907
Merged
1 task
mike-winberry pushed a commit that referenced this issue Oct 13, 2022
#893. Changed let to const in createComponentStepMap for deployingCom…
fd25ae1 
…ponentMap and component
mike-winberry added a commit that referenced this issue Oct 14, 2022
@mike-winberry @jeff-mccoy
Fixes #893 Deploying steps indexing. (#907)
9a8f839 
## Description

Fix deploy-utils createComponentStepMap step numbering. Removed unused
constant POLL_TIME_MS. Added some commenting in deploy-utils.

Fixes # (issue)
#893 


## Type of change


- [x] Bug fix (non-breaking change which fixes an issue)

Co-authored-by: Megamind <[email protected]>
Repository owner moved this from Doing Now to Done in Zarf Project Board Oct 14, 2022
Noxsios pushed a commit that referenced this issue Mar 8, 2023
@mike-winberry @jeff-mccoy
Fixes #893 Deploying steps indexing. (#907)
0ca1827 
## Description

Fix deploy-utils createComponentStepMap step numbering. Removed unused
constant POLL_TIME_MS. Added some commenting in deploy-utils.

Fixes # (issue)
#893 


## Type of change


- [x] Bug fix (non-breaking change which fixes an issue)

Co-authored-by: Megamind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-winberry mike-winberry

Labels
possible-bug 🐛
Projects
None yet
Milestone
v0.26.1 (Zarf UI)
Development

Successfully merging a pull request may close this issue.

Fixes #893 Deploying steps indexing. zarf-dev/zarf
3 participants
@jeff-mccoy @mike-winberry @Madeline-UX