Fixes #893 Deploying steps indexing. #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d constant POLL_TIME_MS. Added some commenting in deploy-utils.
Screen.Recording.2022-10-13.at.12.21.17.PM.mov |
|
thanks for adding videos on these PRs @mike-winberry, super helpful. |
jeff-mccoy
reviewed
Oct 13, 2022
Noxsios
reviewed
Oct 13, 2022
…ponentMap and component
|
@jeff-mccoy Yes, that was old code and for both of these @Noxsios thanks I am sorely missing my pre-commit hooks, but should be cleaned up now. |
jeff-mccoy
approved these changes
Oct 14, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Fix deploy-utils createComponentStepMap step numbering. Removed unused constant POLL_TIME_MS. Added some commenting in deploy-utils. Fixes # (issue) #893 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) Co-authored-by: Megamind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix deploy-utils createComponentStepMap step numbering. Removed unused constant POLL_TIME_MS. Added some commenting in deploy-utils.
Fixes # (issue)
#893
Type of change