Registry pod affinity #1039
Merged
Registry pod affinity #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PodAffinity - Add HPA - Add PriorityClassName - Add PodDisruptionBudget - Add package variables for resources & PVC size - Add support for package variables on zarf init
|
|
|
Sad times, the daemonset will only be useful on clusters with at least 2 nodes per AZ and even then can be a bit janky, so dropping that part of this. Did verify if a node completely dies you can recover by re-running
Notes on the |
jeff-mccoy
requested review from
YrrepNoj,
Racer159,
Madeline-UX,
JasonvanBrackel,
RothAndrew and
a team
as code owners
jeff-mccoy
force-pushed
the
registry-pod-affinity
branch
from
ef2f0d0 to
3c9cc74
Compare
Racer159
reviewed
Dec 7, 2022
Racer159
reviewed
Dec 7, 2022
Racer159
approved these changes
Dec 7, 2022
|
Thanks for the review @Racer159 I'm going to keep this one open for comment tomorrow since I posted in K8s Slack asking for K8s feedback. |
mikevanhemert
approved these changes
Dec 7, 2022
jeff-mccoy
added a commit
that referenced
this pull request
Dec 8, 2022
Removes a test that was previously needed to make sure a package in a default path was read. Now that #1039 is merged, we have this covered on init package create / deploy + it was was trampling over that file during this test.
Closed
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
This PR changes the behavior of the internal Zarf Registry to behave correctly on mulit-node clusters with storage (a change in v0.22.x made this unstable). Change list: - Use [Pod Affinity](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#an-example-of-a-pod-that-uses-pod-affinity) to force pods onto the same node for proper upgrades/restarts - Add K8s [HPA](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/) to increase performance of image pushes - Add [Priority Classes](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) to the Zarf Agent and Zarf Registry deployments - Add [Pod Disruption Budget](https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets) for the Zarf Registry - Add Zarf variables to support custom registry resources requests/limits, custom PVC size, and alternatively the use of a custom PVC - Move the Zarf Registry chart to a local chart - Fix a small issue with log files not being properly saved for K3s workflows - Fix issue from #934 with cross-platform commands - Remove makefile config overrides and replace with `zarf-config.toml` Fixes #1004 Related to #1062
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Removes a test that was previously needed to make sure a package in a default path was read. Now that #1039 is merged, we have this covered on init package create / deploy + it was was trampling over that file during this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the internal Zarf Registry to behave correctly on mulit-node clusters with storage (a change in v0.22.x made this unstable). Change list:
zarf-config.tomlFixes #1004
Related to #1062