Make Zarf a Library #934
Merged
Make Zarf a Library #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-package-library-wip"
Only parse through requested components if components were actually requested
YrrepNoj
reviewed
Nov 29, 2022
YrrepNoj
reviewed
Nov 30, 2022
YrrepNoj
previously approved these changes
Nov 30, 2022
Racer159
requested changes
Nov 30, 2022
Racer159
approved these changes
Nov 30, 2022
|
Assuming tests still pass I am good with this now (there will be lots of cleanup though so I would argue we should give it a little time to soak on |
Merged
jeff-mccoy
added a commit
that referenced
this pull request
Dec 7, 2022
This PR changes the behavior of the internal Zarf Registry to behave correctly on mulit-node clusters with storage (a change in v0.22.x made this unstable). Change list: - Use [Pod Affinity](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#an-example-of-a-pod-that-uses-pod-affinity) to force pods onto the same node for proper upgrades/restarts - Add K8s [HPA](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/) to increase performance of image pushes - Add [Priority Classes](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) to the Zarf Agent and Zarf Registry deployments - Add [Pod Disruption Budget](https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets) for the Zarf Registry - Add Zarf variables to support custom registry resources requests/limits, custom PVC size, and alternatively the use of a custom PVC - Move the Zarf Registry chart to a local chart - Fix a small issue with log files not being properly saved for K3s workflows - Fix issue from #934 with cross-platform commands - Remove makefile config overrides and replace with `zarf-config.toml` Fixes #1004 Related to #1062
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
This PR is a major refactor of the zarf code base primarily designed around better structure to support the current Zarf API as well as expose some key portions of Zarf as an SDK for other tools to consume. This major refactor came out of growing API needs as well as needs in #892 and the [zarf-controller](https://github.com/defenseunicorns/zarf-controller) prototype. Major changes: - Migrate all global configs used by the packager into [receiver methods](https://medium.com/globant/go-method-receiver-pointer-vs-value-ffc5ab7acdb) to avoid concurrency issues - Migrate from heavy `fatal` use to conventional error bubbling / wrapping - Expose core packager code as `github.com/defenseunicorns/zarf/src/pkg/packager` - Split the k8s package into `github.com/defenseunicorns/zarf/src/pkg/k8s` (external) and `src/internal/cluster` (internal) - Expose `message`, `pki`, and `utils` as `github.com/defenseunicorns/zarf/src/pkg/*` - Move the remaining `src/internal/*` packages (except for `agent` & `api`) into `src/internal/packager/*` - Change K8s connections to a reusable connection, except for `cluster.Tunnel` - Switch to Revive for linting - Introduce language file and establish basic patterns, related to #631 - Add SPDX headers to all files - Begin work to standardize on the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md) - Address a lot of lint issues - Return confirm yaml display to only show populated values Co-authored-by: Jon Perry <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
This PR changes the behavior of the internal Zarf Registry to behave correctly on mulit-node clusters with storage (a change in v0.22.x made this unstable). Change list: - Use [Pod Affinity](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#an-example-of-a-pod-that-uses-pod-affinity) to force pods onto the same node for proper upgrades/restarts - Add K8s [HPA](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/) to increase performance of image pushes - Add [Priority Classes](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) to the Zarf Agent and Zarf Registry deployments - Add [Pod Disruption Budget](https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets) for the Zarf Registry - Add Zarf variables to support custom registry resources requests/limits, custom PVC size, and alternatively the use of a custom PVC - Move the Zarf Registry chart to a local chart - Fix a small issue with log files not being properly saved for K3s workflows - Fix issue from #934 with cross-platform commands - Remove makefile config overrides and replace with `zarf-config.toml` Fixes #1004 Related to #1062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a major refactor of the zarf code base primarily designed around better structure to support the current Zarf API as well as expose some key portions of Zarf as an SDK for other tools to consume. This major refactor came out of growing API needs as well as needs in #892 and the zarf-controller prototype.
Major changes:
fataluse to conventional error bubbling / wrappinggithub.com/defenseunicorns/zarf/src/pkg/packagergithub.com/defenseunicorns/zarf/src/pkg/k8s(external) andsrc/internal/cluster(internal)message,pki, andutilsasgithub.com/defenseunicorns/zarf/src/pkg/*src/internal/*packages (except foragent&api) intosrc/internal/packager/*cluster.Tunnel