Handle release versions on init in a backwards compatible way #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
force-pushed
the
529-zarf-init-should-warn-when-the-binary-is-out-of-sync-with-a-release
branch
from
e927e02 to
7301e89
Compare
|
@Megamind came to this after some discussions with @YrrepNoj as it will pull the correct init release if we ever needed to go backward on a branch and build something (or if a breaking release was just pushed and someone was working off of an older version of the code). We cannot completely get rid of the semver package as it is an indirect dependency of another library. |
|
I also removed the spaces so that the Make versions are correct and do not contain a leading space. |
okay now you're just showing off 😆. |
jeff-mccoy
approved these changes
Aug 8, 2022
Racer159
changed the title
…is-out-of-sync-with-a-release
jeff-mccoy
deleted the
529-zarf-init-should-warn-when-the-binary-is-out-of-sync-with-a-release
branch
3 tasks
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading v in the Zarf version was silently erroring the backwards compatibility for Zarf init package pulling.
Related Issue
Fixes #529
Type of change
Checklist before merging